Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] review function naming #353

Closed
m50S79sM6SRNp8Jn opened this issue Aug 20, 2023 · 2 comments
Closed

[Issue] review function naming #353

m50S79sM6SRNp8Jn opened this issue Aug 20, 2023 · 2 comments

Comments

@m50S79sM6SRNp8Jn
Copy link

m50S79sM6SRNp8Jn commented Aug 20, 2023

It's important to use consistent and accurate naming conventions in programming to make code more understandable and maintainable.

on_date_change is really on_date_changed
on_progress_change is really on_progress_changed
on_view_change is really on_view_changed
<other?>

Actually, I prefer to have both the on...change and the on...changed functions (not a simple renaming).

Anyhow, you will have a breaking change.

@safwansamsudeen
Copy link
Collaborator

While I agree with the proposed change, I don't think it makes sense to have a breaking change now...

...unless we're anyway planning to release a major version soon. What do you think @netchampfaris?

@safwansamsudeen safwansamsudeen closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2024
@netchampfaris
Copy link
Collaborator

@m50S79sM6SRNp8Jn @safwansamsudeen

I don't think there's any problem with the event naming. Even HTML events are named like this.
For e.g., when you interact with an input, it fires the change event and not changed.

Ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/change_event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants