Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid rejected leave application on leave check #1848

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Jun 5, 2024

No description provided.

@ruchamahabal ruchamahabal merged commit e534594 into frappe:develop Jun 6, 2024
6 checks passed
mergify bot pushed a commit that referenced this pull request Jun 6, 2024
* fix: avoid rejected leave application on leave check

* chore: fix linter

---------

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit e534594)
mergify bot pushed a commit that referenced this pull request Jun 6, 2024
* fix: avoid rejected leave application on leave check

* chore: fix linter

---------

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit e534594)
ruchamahabal pushed a commit that referenced this pull request Jun 6, 2024
…#1850)

* fix: avoid rejected leave application on leave check

* chore: fix linter

---------

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit e534594)

Co-authored-by: Dany Robert <danyrt@wahni.com>
ruchamahabal pushed a commit that referenced this pull request Jun 6, 2024
…#1849)

* fix: avoid rejected leave application on leave check

* chore: fix linter

---------

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit e534594)

Co-authored-by: Dany Robert <danyrt@wahni.com>
frappe-pr-bot pushed a commit that referenced this pull request Jun 7, 2024
## [14.28.4](v14.28.3...v14.28.4) (2024-06-07)

### Bug Fixes

* avoid rejected leave application on leave check (backport [#1848](#1848)) ([#1849](#1849)) ([50f490c](50f490c))
* don't overwrite leave approver while renderingleave summary dashboard ([38bed0b](38bed0b))
* **UX:** link employee & department doc in the error message for missing leave approver ([849b7ea](849b7ea))
frappe-pr-bot pushed a commit that referenced this pull request Jun 7, 2024
## [15.22.1](v15.22.0...v15.22.1) (2024-06-07)

### Bug Fixes

* avoid rejected leave application on leave check (backport [#1848](#1848)) ([#1850](#1850)) ([4a11d98](4a11d98))
* don't overwrite leave approver while renderingleave summary dashboard ([841a1dc](841a1dc))
* **PWA:** fetch HR Settings from API instead of `documentResource` to avoid permission issues (backport [#1861](#1861)) ([#1862](#1862)) ([883e0ea](883e0ea))
* **PWA:** strip html tags in holiday descriptions (backport [#1829](#1829)) ([#1830](#1830)) ([abaf45c](abaf45c))
* **UX:** link employee & department doc in the error message for missing leave approver ([2ba079b](2ba079b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants