fix(PWA): fetch HR Settings from API instead of documentResource to avoid permission issues (backport #1861)
#1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
## [15.22.1](v15.22.0...v15.22.1) (2024-06-07) ### Bug Fixes * avoid rejected leave application on leave check (backport [#1848](#1848)) ([#1850](#1850)) ([4a11d98](4a11d98)) * don't overwrite leave approver while renderingleave summary dashboard ([841a1dc](841a1dc)) * **PWA:** fetch HR Settings from API instead of `documentResource` to avoid permission issues (backport [#1861](#1861)) ([#1862](#1862)) ([883e0ea](883e0ea)) * **PWA:** strip html tags in holiday descriptions (backport [#1829](#1829)) ([#1830](#1830)) ([abaf45c](abaf45c)) * **UX:** link employee & department doc in the error message for missing leave approver ([2ba079b](2ba079b))
|
🎉 This PR is included in version 15.22.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attendance feature flags for checkin were being fetched from HR Settings using
documentResource.get_docis permission sensitive so if the employee's permissions for reading HR Settings is removed, the checkin button is not visible in the mobile app even if of mobile checkins are enabled.This is an automatic backport of pull request #1861 done by Mergify.