fix(Shift Assignment): overlapping timings validation #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ift (and vice versa)
- fix shift overlapping timings tests - refactor tests to use helper functions and improve readability - remove redundant test test_multiple_shift_assignments_for_same_day
ruchamahabal
approved these changes
Jul 17, 2024
This was referenced Jul 17, 2024
ruchamahabal
added a commit
that referenced
this pull request
Jul 17, 2024
…1932 fix(Shift Assignment): overlapping timings validation (backport #1932)
ruchamahabal
added a commit
that referenced
this pull request
Jul 17, 2024
…1932 fix(Shift Assignment): overlapping timings validation (backport #1932)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two overlooked cases for overlapping shift timings (for the same date):-
Case 1
Shift 1:- 22:00 - 4:00
Shift 2:- 2:00 - 8:00
Shift 2 would be marked as overlapping even though it isn't. (Shift 1 starts 14 hours after Shift 2 ends)
Case 2
Shift 1:- 8:00 - 12:00
Shift 2:- 14:00 - 18:00
Shift 3:- 16:00 - 20:00
Shift 3 would not be marked as overlapping even though it is, with Shift 2.