fix(Shift Assignment): overlapping timings validation (backport #1932) #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 981c756)
…ift (and vice versa) (cherry picked from commit 5e880f2)
- fix shift overlapping timings tests - refactor tests to use helper functions and improve readability - remove redundant test test_multiple_shift_assignments_for_same_day (cherry picked from commit 155b815)
(cherry picked from commit 0ea2d12)
|
🎉 This issue has been resolved in version 15.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two overlooked cases for overlapping shift timings (for the same date):-
Case 1
Shift 1:- 22:00 - 4:00
Shift 2:- 2:00 - 8:00
Shift 2 would be marked as overlapping even though it isn't. (Shift 1 starts 14 hours after Shift 2 ends)
Case 2
Shift 1:- 8:00 - 12:00
Shift 2:- 14:00 - 18:00
Shift 3:- 16:00 - 20:00
Shift 3 would not be marked as overlapping even though it is, with Shift 2.
This is an automatic backport of pull request #1932 done by Mergify.