Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning: Invalid 'main' field in package.json #1122

Closed
frankl7800 opened this issue Jan 7, 2022 · 3 comments
Closed

DeprecationWarning: Invalid 'main' field in package.json #1122

frankl7800 opened this issue Jan 7, 2022 · 3 comments
Labels

Comments

@frankl7800
Copy link

DeprecationWarning: Invalid 'main' field in '...\node_modules@frctl\fractal\node_modules@frctl\handlebars\package.json' of 'src/index.js'.

Steps to reproduce the issue

  1. Start Styleguide by grunt-Task
  2. When finished:
Running "concurrent:tasks" (concurrent) task
    Running "watch" task
    Waiting...
    Running "fractal-serve:all" (fractal-serve) task
    (node:16124) [DEP0128] DeprecationWarning: Invalid 'main' field in 'E:\GIT\...\node_modules\@frctl\fractal\node_modules\@frctl\handlebars\package.json' of 'src/index.js'. Please either fix that or report it to the module author
    (Use `node --trace-deprecation ...` to show where the warning was created)
    Fractal server is now running at http://localhost:3000

Reproduces how often:
100%

Context

  • Fractal version: 1.5.11
  • Node version: 16.13.0
  • OS: Windows 10
@frankl7800 frankl7800 added the bug label Jan 7, 2022
@mihkeleidast
Copy link
Member

Hey @frankl7800! This should've been fixed with #1060 - released with @frctl/handlebars v1.2.11 and @frctl/fractal v1.5.9. Can you maybe investigate a bit further, where the old handlebars adapter is coming from? Or try updating it to the latest manually with npm update @frctl/handlebars?

@frankl7800
Copy link
Author

My handlebars adapter is version 1.2.13 and comming from yarn: https://yarnpkg.com/package/@frctl/handlebars

yarn list --pattern "frctl"

yarn list v1.22.15
├─ @frctl/core@0.3.3
├─ @frctl/fractal@1.5.11
│  └─ @frctl/mandelbrot@1.9.4
├─ @frctl/handlebars@1.2.13
├─ @frctl/mandelbrot@1.7.0
└─ @frctl/web@0.1.10

@mihkeleidast
Copy link
Member

If I look at my own current project where I also have 1.2.13 installed, inspect the actually installed package, it seems to be fine:
image

The code in this repo is also correct for the handlebars adapter. I'll close the issue, but feel free to ping me if you find out something new (e.g. we've been looking at the wrong package or whatever)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants