-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What's the difference between this driver and the upstream one? #4
Comments
The main difference is the nct6683 is not the same chipset as nct6687, and command line sensor with the nct6683 module report wrong value for temp and voltage. I have tested it by recompiling the source nct6683.c from 5.10 on kernel 5.4 & 5.8. Also temp/voltage labels are also wrong, the number of register aren't the same. The only thing working correctly is fan sensor. About 5.11 I don't have tested yet, but the source code nct6683.c looks like the same. |
Thanks. I'm gonna compile this module too, and compare the results, and paste them here. |
these were taken in a 2 second period nct6683.ko
nct6687.ko
module loading info:
|
As you can see, voltage are not correct, values & labels
It's not correct labels provided by the module. It must be:
|
I have some label overrides in |
ps. which m2 slot is m2_1? because I do have a nvme in the m2_1 slot, the one connected to the cpu. it reports its own temperature, but here it says 0⁰. also, |
@gdamjan - Thanks for the work on this. I have the same question:
|
The upstream drivers usually don't apply scaling factors to voltages, especially for newer hardware, so that is expected. I've attached my configuration file as an example for those who are interested. (Remove the .txt at the end, only needed for uploading the file.) I'm not yet sure what to do with the additional voltage registers |
The Linux kernel got to support the nct6687d chip (in the nct6683 module) with 5.11 (now at -rc5)
torvalds/linux@daf4fed
What is the difference between this and that driver?
The text was updated successfully, but these errors were encountered: