Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically install devDependencies? #31

Closed
mfolkeseth opened this issue Mar 29, 2019 · 5 comments
Closed

Automatically install devDependencies? #31

mfolkeseth opened this issue Mar 29, 2019 · 5 comments

Comments

@mfolkeseth
Copy link

Before anything else, I just want to give you guys some props for this awesome project. Grat work! 🎉

Now over to my question. I was just wondering if there is any particular reason why pika ignores devDependences by default (unless webDependenceies is set in package.json). Am I missing something?

@ematipico
Copy link
Contributor

Why would you need a dev dependency when you run your application in production?

@mfolkeseth
Copy link
Author

This setup works great in out dev mode, but not in our production setup. It can be solved through webDependencies so it's not an issue, just a question 😄

@FredKSchott
Copy link
Owner

Thanks @mfolkeseth! The only reason was that a project could have a lot of devDependencies, and most of the related to node.js tooling, so most of them wouldn't make sense for the web. I think that still makes sense as a default, especially since the whitelist exists.

Trying to be good about moving feature discussions to Spectrum (and keeping Github issues for bugs & prs) so feel free to continue the discussion here -> https://spectrum.chat/pika/pika-pack/automatically-install-devdependencies-31~0f6032df-f1f3-4145-9be4-395683e49c17

@mfolkeseth
Copy link
Author

Thanks @FredKSchott! That was kind of the answer I expected 👍
There are no stupid questions, right 😄

@FredKSchott
Copy link
Owner

RIGHT! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants