Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reloadGrid fails because of p not initialized. #408

Closed
wants to merge 2 commits into from
Closed

reloadGrid fails because of p not initialized. #408

wants to merge 2 commits into from

Conversation

luytk12
Copy link

@luytk12 luytk12 commented Dec 19, 2017

Property p is not correctly initialized.

Property p is not correctly initialized.
moved self.p
OlegKi added a commit that referenced this pull request Dec 19, 2017
Thanks @luytk12 (https://github.com/luytk12) for pointing to the problem. See [pull request #408](#408) for more details.
@OlegKi
Copy link
Member

OlegKi commented Dec 19, 2017

Thanks for pointing of that! Currently reloadGrid works correctly, but p will be used from the outer scope, which has some minor disadvantages. I agree, that it would be better to define local variable via p = self.p. On the other side, your last changes (see here) don't declare local variable p and just overwrite p defined in the outer scope. Such code have no advantage comparing with the current code of free jqGrid. Thus I'm closing your pull request and declare p = self.p (like here) in the separate commit.

@OlegKi OlegKi closed this Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants