Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop development branch #32

Closed
cmfcmf opened this issue Jul 12, 2020 · 2 comments
Closed

Drop development branch #32

cmfcmf opened this issue Jul 12, 2020 · 2 comments

Comments

@cmfcmf
Copy link
Member

cmfcmf commented Jul 12, 2020

I don't think we necessarily need both a development and production branch. It adds an extra step of unnecessary complexity and it also breaks the GitHub Action that refreshes the community projects once per day, which always deploys the default (= development) branch. This is why some changes from the development branch are already live at free-pdk.github.io, even though development has not yet been merged into production.

I would therefore like to delete the production branch and rename the development branch to production. Would that be okay with you?

@cpldcpu
Copy link
Member

cpldcpu commented Jul 12, 2020

It seems that Netlify will also build previews from all pull requests, right? In that case the development branch could be dropped indeed. I only introduced it to simplify testing of multiple changes.

@cmfcmf
Copy link
Member Author

cmfcmf commented Jul 13, 2020

It seems that Netlify will also build previews from all pull requests, right?

yes 👍

I only introduced it to simplify testing of multiple changes.

I see! Thank you for the explanation.

@cmfcmf cmfcmf closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants