-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Padauk Links to separate column #35
Conversation
Deploy preview for free-pdk-preview ready! Built without sensitive environment variables with commit 1ed0811 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done 👍
Still not happy with the scrollbar on the OTP Variants: Looks like the ROM column is pushing it out. We could try and reduce the OSS Status column more somehow? My original thought is we would have two lines, one for Easy PDK Programmer with a minimum version number, and another for SDCC with a minimum version number. Not sure the best way to indicated all that and also reduce the space though. Thoughts on how to fix? |
We could decrease the padding of the table cells by replacing this: free-pdk.github.io/assets/main.scss Lines 23 to 29 in fd4360b
by this: table {
p {
margin: 0;
}
td, th {
text-align: center;
padding: 10px 10px; // <--
}
} |
We could also make the page slightly wider. Currently at 1040px, which still feels a little narrow to me. Preference? |
I personally prefer the page width as it is right now. |
I'm curious why 1040? It is bigger than 1024 x ..., but quite a ways from the next logical size 1280 x ..., so it leaves some wider gutters. Even just going up to 1060 fixes the scrollbar, although I think it looks even better at 1140 (and still leaves enough gutter).
I'll play around with that too. |
Actually, simply changing the padding as you indicated looks good too. We can just stick to that for now. |
Hmm... the preview site looks ok, but the production site isn't applying the padding override. Any ideas? EDIT: looks like my browser was caching the css. A clear cache / hard reload fixed it for me. |
I would suggest to use a |
No description provided.