Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Padauk Links to separate column #35

Merged
merged 8 commits into from
Jul 13, 2020

Conversation

serisman
Copy link
Contributor

No description provided.

@serisman serisman mentioned this pull request Jul 13, 2020
@netlify
Copy link

netlify bot commented Jul 13, 2020

Deploy preview for free-pdk-preview ready!

Built without sensitive environment variables with commit 1ed0811

https://deploy-preview-35--free-pdk-preview.netlify.app

Copy link
Member

@cmfcmf cmfcmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍

@serisman
Copy link
Contributor Author

serisman commented Jul 13, 2020

Still not happy with the scrollbar on the OTP Variants:

image

Looks like the ROM column is pushing it out.

We could try and reduce the OSS Status column more somehow? My original thought is we would have two lines, one for Easy PDK Programmer with a minimum version number, and another for SDCC with a minimum version number. Not sure the best way to indicated all that and also reduce the space though.

Thoughts on how to fix?

@cmfcmf
Copy link
Member

cmfcmf commented Jul 13, 2020

We could decrease the padding of the table cells by replacing this:

table p {
margin: 0;
}
td, th {
text-align: center;
}

by this:

table {
  p {
    margin: 0;
  }

  td, th {
    text-align: center;
    padding: 10px 10px; // <-- 
  }
}

@serisman
Copy link
Contributor Author

serisman commented Jul 13, 2020

We could also make the page slightly wider. Currently at 1040px, which still feels a little narrow to me.

Preference?

@cmfcmf
Copy link
Member

cmfcmf commented Jul 13, 2020

I personally prefer the page width as it is right now.
Another option would be decreasing the font size inside tables to 14 or 15 px.

@serisman
Copy link
Contributor Author

I personally prefer the page width as it is right now.

I'm curious why 1040? It is bigger than 1024 x ..., but quite a ways from the next logical size 1280 x ..., so it leaves some wider gutters. Even just going up to 1060 fixes the scrollbar, although I think it looks even better at 1140 (and still leaves enough gutter).

Another option would be decreasing the font size inside tables to 14 or 15 px.

I'll play around with that too.

@serisman
Copy link
Contributor Author

Actually, simply changing the padding as you indicated looks good too. We can just stick to that for now.

@serisman
Copy link
Contributor Author

image

@serisman serisman merged commit 719172e into free-pdk:production Jul 13, 2020
@serisman
Copy link
Contributor Author

serisman commented Jul 13, 2020

Hmm... the preview site looks ok, but the production site isn't applying the padding override. Any ideas?

EDIT: looks like my browser was caching the css. A clear cache / hard reload fixed it for me.

@cpldcpu
Copy link
Member

cpldcpu commented Jul 13, 2020

I would suggest to use a &nbsp; for "product page" to avoid linebreaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants