This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
feat: add event images #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ojeytonwilliams
commented
Aug 23, 2021
| boxSize="100%" | ||
| maxH="300px" | ||
| src={data.event.image} | ||
| alt="The freeCodeCamp logo" |
There was a problem hiding this comment.
Can we add the alt text when adding the image and then use it here?
There was a problem hiding this comment.
Sure a field called description should do it.
There was a problem hiding this comment.
Thinking about it, this is purely decorative. We can just require alt="" since screenreaders can safely ignore it.
client/src/modules/dashboard/Events/components/EventFormUtils.ts
Outdated
Show resolved
Hide resolved
This was referenced Aug 23, 2021
ojeytonwilliams
force-pushed
the
feat/add-event-images
branch
from
dcf9b5a
to
a062ab6
Compare
ojeytonwilliams
force-pushed
the
feat/add-event-images
branch
from
eb29466
to
42aa835
Compare
ahmaxed
reviewed
Oct 4, 2021
| @@ -0,0 +1,13 @@ | |||
| import { MigrationInterface, QueryRunner } from 'typeorm'; | |||
There was a problem hiding this comment.
Not sure, but since we are introducing "image_url" for first time here we would not need a migration file?
There was a problem hiding this comment.
Nope, we're not using explicit migration files now, since typeorm can set up the db for us without them. I'll remove this file while I sort out the conflicts.
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
It's a purely decorative image
ojeytonwilliams
force-pushed
the
feat/add-event-images
branch
from
42aa835
to
560c39e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated after I accidentally merged the last one: #651