fix: portfolio card style (#54582)

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com> Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
freeCodeCamp · May 8, 2024 · 8ed2909 · 8ed2909
1 parent a0b99a0
commit 8ed2909
Show file tree

Hide file tree

Showing 4 changed files with 66 additions and 108 deletions.
diff --git a/client/i18n/locales/english/translations.json b/client/i18n/locales/english/translations.json
@@ -303,7 +303,7 @@
     "fcc-certs": "freeCodeCamp Certifications",
     "longest-streak": "Longest Streak:",
     "current-streak": "Current Streak:",
-    "portfolio": "Portfolio",
+    "projects": "Projects",
     "timeline": "Timeline",
     "none-completed": "No challenges have been completed yet.",
     "get-started": "Get started here.",

diff --git a/client/src/components/profile/components/portfolio-projects.css b/client/src/components/profile/components/portfolio-projects.css
@@ -1,117 +1,70 @@
-.portfolio-container {
-  display: grid;
-  position: relative;
-  border: 1px solid var(--secondary-color);
-  gap: 1rem 1rem;
-  grid-template-columns: repeat(3, 1fr);
-  margin-top: 1em;
-  margin-bottom: 3em;
+/* Base styles for mobile devices */
+.portfolio-card {
+  display: flex;
+  flex-direction: column;
+  margin-top: 2rem;
+  width: 100%;
+  height: auto;
+  overflow: hidden;
 }
 
-.portfolio-screen-shot {
-  display: block;
+.portfolio-image {
+  position: relative;
   width: 100%;
-  height: 100%;
+  height: 200px;
   object-fit: cover;
-  grid-column: 1/-1;
-  grid-row: 1;
 }
 
-.portfolio-container h3 {
-  grid-column: 1/ -1;
-  grid-row: 2;
-  margin-block: 1em;
+.portfolio-card-description {
+  margin: 1rem 0rem;
+  width: auto;
+  overflow-wrap: break-word;
 }
 
 #link-icon {
-  margin-inline-start: 1em;
+  margin-inline-start: 10px;
 }
 
-.portfolio-container a {
-  display: flex;
-  align-items: center;
-  justify-content: center;
-  grid-column: 1/ -1;
-  grid-row: 4;
-  font-size: unset;
-  justify-self: end;
-  width: 40%;
-  height: 40px; /* Set a fixed height value */
-  background-color: var(--quaternary-background);
-  color: var(--secondary-color);
-  padding: 0.5rem;
-  border: 3px solid var(--secondary-color);
-  padding-inline: 4rem;
-  margin: 1em;
+a.portfolio-card {
   text-decoration: none;
-  /* prevent line breaks in Chinese/Japanese/Korean */
-  word-break: keep-all;
-}
-
-.portfolio-container:hover a {
-  background-color: var(--primary-color);
-  color: var(--primary-background);
 }
 
-.portfolio-container a::after {
-  content: '';
-  position: absolute;
-  inset: 0;
-  width: 100%;
-  height: 100%;
-  z-index: 1;
+.portfolio-card p {
+  margin-bottom: 10px;
 }
 
-.portfolio-container a:is(:hover, :focus, :focus-visible) {
-  outline-offset: 2px;
+a.portfolio-card:hover,
+a.portfolio-card:focus {
+  background-color: transparent;
 }
 
-.portfolio-container p {
-  display: -webkit-box;
-  -webkit-box-orient: vertical;
-  overflow: hidden;
-  grid-column: 1/ -1;
-  grid-row: 3;
+a.portfolio-card:hover h3,
+a.portfolio-card:focus h3 {
+  text-decoration: underline;
 }
 
-@media (max-width: 994px) {
-  .portfolio-screen-shot {
-    max-height: 300px;
-  }
-
-  .portfolio-container h3 {
-    margin: 0.5rem;
-  }
-
-  .portfolio-container p {
-    margin: 1rem;
-  }
+a.portfolio-card:hover img,
+a.portfolio-card:focus img {
+  opacity: 0.8;
 }
 
-@media (min-width: 995px) {
-  .portfolio-container {
-    grid-template-columns: 450px 1.2fr;
-    grid-template-rows: minmax(65px, 0.1fr) minmax(125px, 1fr) 75px;
-  }
-
-  .portfolio-screen-shot {
-    grid-column: 1;
-    grid-row: 1 / -1;
-  }
-
-  .portfolio-container h3 {
-    grid-column: 2;
-    grid-row: 1;
+/* Adjust styles for desktop screens */
+@media (min-width: 769px) {
+  .portfolio-card {
+    flex-direction: row;
+    min-width: 0;
+    max-height: none;
   }
 
-  .portfolio-container p {
-    grid-column: 2;
-    grid-row: 2;
+  .portfolio-image {
+    width: 300px;
+    min-width: 300px;
+    min-height: auto;
   }
 
-  .portfolio-container a {
-    grid-column: 2;
-    grid-row: 3;
+  .portfolio-card-description {
+    margin: 0rem 1rem 1rem;
+    width: 100%;
   }
 }
 
@@ -122,6 +75,7 @@
   display: flex;
   justify-content: center;
   align-items: center;
+  margin: 0.5rem;
 }
 
 .timeline-pagination_list_item {
@@ -132,7 +86,6 @@
   outline-color: transparent;
 }
 
-/* Timeline table styles */
 .timeline-row {
   height: 60px;
 }

diff --git a/client/src/components/profile/components/portfolio-projects.tsx b/client/src/components/profile/components/portfolio-projects.tsx
@@ -1,9 +1,8 @@
 import React from 'react';
 import { useTranslation } from 'react-i18next';
-import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
-import { faArrowUpRightFromSquare } from '@fortawesome/free-solid-svg-icons';
 import type { PortfolioProjectData } from '../../../redux/prop-types';
 import './portfolio-projects.css';
+import { FullWidthRow } from '../../helpers';
 
 interface PortfolioProjectsProps {
   portfolioProjects: PortfolioProjectData[];
@@ -17,33 +16,39 @@ export const PortfolioProjects = ({
     return null;
   }
   return (
-    <>
-      <h2 className='text-center'>{t('profile.portfolio')}</h2>
+    <FullWidthRow>
+      <h2 className='text-center'>{t('profile.projects')}</h2>
       {portfolioProjects.map(({ title, url, image, description, id }) => (
-        <div className='portfolio-container' key={id}>
-          <h3>{title}</h3>
-          <p>{description}</p>
-          <a href={url} rel='nofollow noopener noreferrer' target='_blank'>
-            {t('buttons.view')}
-            <span className='sr-only'>
-              {title}, {t('aria.opens-new-window')}
-            </span>
-            <FontAwesomeIcon id='link-icon' icon={faArrowUpRightFromSquare} />
-          </a>
+        <a
+          href={url}
+          rel='nofollow noopener noreferrer'
+          target='_blank'
+          className='portfolio-card'
+          key={id}
+        >
           {image && (
             <img
               alt=''
-              className='portfolio-screen-shot'
+              className='portfolio-image'
               src={image}
               onError={({ currentTarget }) => {
                 currentTarget.src =
                   'https://cdn.freecodecamp.org/platform/universal/fcc_meta_1920X1080-indigo.png';
               }}
             />
           )}
-        </div>
+          <div className='portfolio-card-description'>
+            <div className='portfolio-card-text'>
+              <h3>
+                {title}
+                <span className='sr-only'>, {t('aria.opens-new-window')}</span>
+              </h3>
+              <p>{description}</p>
+            </div>
+          </div>
+        </a>
       ))}
       <hr />
-    </>
+    </FullWidthRow>
   );
 };
diff --git a/e2e/profile.spec.ts b/e2e/profile.spec.ts
@@ -172,7 +172,7 @@ test.describe('Profile component', () => {
   test('should not show portfolio when empty', async ({ page }) => {
     // @certifieduser doesn't have portfolio information
     await expect(
-      page.getByText(translations.profile.portfolio)
+      page.getByText(translations.profile.projects)
     ).not.toBeVisible();
   });