-
-
Notifications
You must be signed in to change notification settings - Fork 37k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: portfolio card style #54582
fix: portfolio card style #54582
Conversation
0858a82
to
6f3bfae
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@ahmaxed, you are using an older version of the branch please update :) |
I just tested the PR locally and the changes look great. I think the user would know that the title and the image are a link thanks to the pointer cursor and the hover state (the title has an underline, and the image has an overlay). Though I'm wondering if we could/should add a border around the Alternatively, I guess we could copy /news and have the image and the title as separate links? |
Thanks for the feedback. The border is going to look strange if the description and the title exceed the height of the image. Since there is a lot of space between the two cards, finding and clicking on the desired card should be straightforward. |
client/src/components/profile/components/portfolio-projects.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
The new design for the project cards. I and Ahmad decided on a new design, this design offers consistency with our news platform. Meaning, the cards look like the landing page on news. While keeping the flexibility of the old design.
We need to make sure this is what we want.
related to #48234