Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass challenges don't work #12699

Closed
ryanarnouk opened this issue Jan 21, 2017 · 39 comments
Closed

Sass challenges don't work #12699

ryanarnouk opened this issue Jan 21, 2017 · 39 comments
Assignees
Labels
help wanted Open for all. You do not need permission to work on these. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping.

Comments

@ryanarnouk
Copy link
Contributor

ryanarnouk commented Jan 21, 2017

Challenge storing-data-with-sass-variables has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36.

    
    
<style>
$text-color: red;

.header{
  text-align: center;
}
.blog-post h2 {
  color: $text-color;
}
</style>

<h1 class="header">Learn Sass</h1>
<div class="blog-post">
<h2>Some random title</h2>
<p>This is a paragraph with some random text in it</p>
</div>
<div class="blog-post">
<h2>Header #2</h2>
<p>Here is some more random text.</p>
</div>
<div class="blog-post">
<h2>Here is another header</h2>
<p>Even more random text within a paragraph</p>
</div>

Hello Everyone, I think I found a bug in the challenge Storing Data With Sass Variables. I think I did everything right, but the h2 and the .blog-post elements colour doesn't change to red. I pass two of the user stories but not these:
Your .blog-post element should have a color of red.
Your h2 elements should have a color of red.

It also doesn't change red. But it passes the user stories:
Your code should have a Sass variable declared for $text-color with a value of red.
Your code should use the $text-color variable to change the color for the .blog-post and h2 items

Thank you in advance, and the new things in Beta seem amazing keep up the great work! Can't wait to work through more of them! 👍

@systimotic
Copy link
Member

@Azbo400 Thank you for reporting this issue. It looks like we don't actually support compiling the Sass yet 😅

@ryanarnouk
Copy link
Contributor Author

@systimotic Oh haha, that makes sense! Thank you 😄

@HKuz
Copy link
Member

HKuz commented Jan 21, 2017

Oh sorry! We should have given folks a head's up that this section wouldn't work properly. Thanks for the issue, @Azbo400

@ryanarnouk
Copy link
Contributor Author

@HKuz That's fine, no problem. 😃

@pramodpots
Copy link

Yeah. Its not working. Will there be any notification when it is fixed?

@ChrisD1986
Copy link

ChrisD1986 commented Jan 22, 2017 via email

@rudolphh
Copy link

rudolphh commented Feb 6, 2017

They don't want any sass from you. Jokes

@betaalpha987
Copy link

I agree that it'd be a good idea to warn people that Sass doesn't work yet.

In the meanwhile, I recommend folks follow the Sass official page's guide to installing a Sass compiler and following their guide (and / or FCC's Sass tutorials) on their own machines. The guide starts here: http://sass-lang.com/install

@QuincyLarson QuincyLarson added status: on the roadmap Long term plans and features. and removed beta labels Sep 2, 2017
@systimotic systimotic changed the title [Beta] Challenge Storing Data With Sass Variables doesn't pass 2 user stories. Sass challenges don't work Sep 3, 2017
@QuincyLarson QuincyLarson added beta type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping. and removed status: on the roadmap Long term plans and features. labels Jan 24, 2018
@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 19, 2018
@QuincyLarson QuincyLarson removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 19, 2018
@MikeForde
Copy link

No agreed, there's more to it than white space. What I did notice is that - with the @while example - if I keep pressing the "Run the Tests" button then - if there are no actual errors - after 4-5 presses, it works, whereas if there is a genuine error it never passes. Not exactly ideal behaviour but would suggest a low-level error rather than one linked to an actual syntactic error in the code being submitted by the user.

@2series
Copy link

2series commented Jul 13, 2018

Hi all, whatever the issues are, they appear to be fix. Passed the challenge first time & i'm using Chrome Version 67.0.3396.87 (Official Build) (64-bit)

@Chaoticonomist
Copy link

Nope, still happening to me when I try the tests. Seem to only affect some users.

@CQW-Code
Copy link

CQW-Code commented Jul 17, 2018

Ran into the same issue-- FireFox 56.0.2.
Cleared all the whitespaces out; indenting etc checked.
Last two tests still failed. Attempting to "spam" the Run Test button.. so far no luck.

=====
edit: I finally did get it to work. Don't recall whether it was due to some minor error on my part or just patiently hitting the "Run Tests" button repeatedly. I wound up doing the "mash the Run Tests button" method on several SASS lessons after this one.

@mahmoud-coo6
Copy link

mahmoud-coo6 commented Jul 19, 2018

here trick for Sass: Use @for to Create a Sass Loop :
there is no second chance because there is bug in this challenge for sure..

<style type='text/sass'> @for $j from 1 through 5 { .text-#{$j} { font-size: 10px* $j; } } </style>

Hello

Hello

Hello

Hello

Hello

1

@dikiaap
Copy link

dikiaap commented Jul 22, 2018

You may add your color style to div tag. This works for me.

<div class="blog-post" style="color: red;">

screenshot from 2018-07-22 18-38-20

@dikiaap
Copy link

dikiaap commented Jul 22, 2018

@mahmoud-coo6 Does your method work on Apply a Style Until a Condition is Met with @while?
I have a warning here: Your .text-1 class should have a font-size of 5px.
I'm pretty sure the font-size is 5px.

@mahmoud-coo6
Copy link

I fix Apply a Style Until a Condition is Met with @while? Challenge by using Firefox instead of google-chrome it's worked for me.

@flyfishingbarbara
Copy link

i had add background style to the div tags..... to get these bugged sass challenges to pass their test....!!

<div class="blue-bg" style="background-color: blue"></div>
<div class="black-bg" style="background-color: black"></div>
<div class="red-bg" style="background-color: red"></div>

@mahmoud-coo6
Copy link

mahmoud-coo6 commented Jul 27, 2018

here the solution @flyfishingbarbara : there some time not worked because there is bug in website

<style type='text/sass'> @each $color in blue,black, red { .#{$color}-bg { background-color: $color;} } div { height: 200px; width: 200px; } </style>

35435

@drex44
Copy link

drex44 commented Aug 27, 2018

the issue is back with @for and @each.
screenshot_2018-08-27 sass use for to create a sass loop learn freecodecamp

screenshot_2018-08-27 sass use each to map over items in a list learn freecodecamp

@Rock-son
Copy link

Rock-son commented Sep 4, 2018

It wouldn't work on Chrome 68.0.3440.106 and not on Opera 55.0 but it worked flawlessly on Firefox 59.0.2 (all 64-bit). Last three exercises did need a bit of "Run the Test" button spaming though

@raisedadead raisedadead added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. hacktoberfest and removed first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. labels Oct 21, 2018
@paulywill
Copy link
Member

@raisedadead @ValeraS
Does this close this issue?
#27716

@ValeraS
Copy link
Contributor

ValeraS commented Oct 31, 2018

@paulywill This is not related to this issue, and the issue has already been solved in the master branch.

@ZTYZZ
Copy link

ZTYZZ commented Mar 24, 2019

lol, I met the same problem...

@RandellDawson
Copy link
Member

@ZTYZZ Do you experience the same problem on the beta site?

@nmichalakis
Copy link

On Firefox Developer Edition (72.0b2 (64-bit)) it does not work.

@RandellDawson
Copy link
Member

@nmichalakis What errors are you seeing in the browser console?

@nmichalakis
Copy link

@RandellDawson i found the "bug" if there is a space between the variable name and the ":" it does not compile correctly. Is this something that happens on plain .scss files too?
So for example if i run
$var-name : color; (a space before and after ":" ) it does not compile but if i run the same
$var-name: color (no space right after $var declaration, it works!)
Screenshot 2019-12-04 at 22 30 18
Screenshot 2019-12-04 at 22 26 46

@raisedadead
Copy link
Member

Please open a fresh issue with these details. Thanks.

@Ukmandal
Copy link

SASS use-each-to-map-over-items-in-a-list beta challenge impossible

@each $color in blue, black, red {
.#{$color}-bg {background-color: $color;}
}

@freeCodeCamp freeCodeCamp locked as resolved and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Open for all. You do not need permission to work on these. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping.
Projects
None yet
Development

No branches or pull requests