Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(curriculum): check tests against solutions #27716

Merged
merged 4 commits into from
Oct 24, 2018

Conversation

ValeraS
Copy link
Contributor

@ValeraS ValeraS commented Oct 24, 2018

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

Test checks challenge tests against solutions for the following type of challenges:

  • html/css/sass
  • js
  • modern (jQuery, React, Redux, d3)

Solutions for challenges should contain seed code from a challengeSeed section. See for example 9f64fab

@ValeraS ValeraS requested a review from a team October 24, 2018 07:12
@ValeraS ValeraS added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: tests labels Oct 24, 2018
@Bouncey Bouncey self-assigned this Oct 24, 2018
@raisedadead raisedadead merged commit 5913095 into freeCodeCamp:master Oct 24, 2018
@Bouncey
Copy link
Member

Bouncey commented Oct 24, 2018

@ValeraS I can't get the test suit to pass locally, it looks like the test suit fails silently, seemingly at random, mid test.

If I remove the pipe to tap-spec then it looks like all the tests run without error. I even tried swapping put tap-spec for tap-difflet. With tap-difflet, if I pass the -p option so it only logs on failed tests, everything works, but with logging everything makes it fail silently again

@raisedadead
Copy link
Member

Let's see if these are random. Here is the master build for this merge https://travis-ci.org/freeCodeCamp/freeCodeCamp/builds/445602013

@ValeraS
Copy link
Contributor Author

ValeraS commented Oct 24, 2018

@Bouncey Let's try to use Mocha instead of Tape. Mocha more precisely identify tests. What do you think?

@ValeraS ValeraS deleted the feat/test-async-tests branch October 26, 2018 13:30
vdkhadke pushed a commit to vdkhadke/freeCodeCamp that referenced this pull request Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants