Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue after claiming full stack certificate - legacy full stack shows error #18253

Closed
moT01 opened this issue Oct 4, 2018 · 15 comments · Fixed by #35608
Closed

Issue after claiming full stack certificate - legacy full stack shows error #18253

moT01 opened this issue Oct 4, 2018 · 15 comments · Fixed by #35608
Assignees
Labels
status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.

Comments

@moT01
Copy link
Member

moT01 commented Oct 4, 2018

I recently claimed my full stack certificate after having all the other certificates (including the 3 non full stack legacy ones) - When I claimed the cert, it showed up on my profile in two spots, the legacy area and the new area - so my profile looks like this...

screen shot 2018-10-04 at 7 46 09 am

I'm not sure if that's intentional or not but the issue is that when I try to open the legacy full stack cert it does not open and I get a flash message that looks like this...

screen shot 2018-09-29 at 11 54 37 am

The one at the top opens as expected
https://www.freecodecamp.org/mot01 <= my profile if you want to see the problem

@qualitymanifest
Copy link

qualitymanifest commented Oct 6, 2018

This issue is a duplicate of #18128

The fix to this particular issue looks fairly simple - I think that removing lines 80-84 from common/app/routes/Profile/components/Certificates.jsx would do it. This of course doesn't address the date problem from the other issue I linked, but should take care of the nonexistent legacy full stack cert.

I'm working on getting the app set up locally right now but hitting some roadblocks and may not have time to figure that out and make a PR for this.

@nischaldutt
Copy link
Contributor

I would like to take a shot at this if anyone else has not taken it up yet?

@moT01
Copy link
Member Author

moT01 commented Oct 12, 2018

@nischaldutt give it a shot - @qualitymanifest that other issue seems to be two different issues in one, so I will leave this open for now, and if it gets fixed we can close this and post over there that the second problem is fixed - thanks for posting where the problem is

@qualitymanifest
Copy link

@moT01 You're right, I should have said they are related, rather than calling it a duplicate. Better to address this issue individually.

Thank you @nischaldutt for taking this

@nischaldutt
Copy link
Contributor

I cannot find the specified file path common/app/routes/Profile/components/Certificates.jsx.
Can you help me figure out where is it located?

@qualitymanifest
Copy link

qualitymanifest commented Oct 12, 2018

Ah. That was from the next branch, but it looks like that branch got removed during the major repo overhaul that happened a few days ago described here https://www.freecodecamp.org/forum/t/hacktoberfest-2018-update/231160

After some searching of the current code, I can't find anything resembling the file I mentioned above, or anything that would cause this issue. However, the issue still persists on the live site, so I am under the assumption that the current master branch isn't live yet.

@nischaldutt
Copy link
Contributor

Thanks for responding! I got it 👍
How much longer will it take to be live any idea?

@qualitymanifest
Copy link

Okay, I think I finally get it now. It's pretty confusing with all these changes. After the repo overhaul, the production branch is the live site (this is pretty obvious, I just didn't think to look for it). FWIW, here is the problem file in the production branch
https://github.com/freeCodeCamp/freeCodeCamp/blob/production/common/app/routes/Profile/components/Certificates.jsx

I am not sure how often the current master branch (what used to be the next branch) will be merged into production, but I believe the problem will no longer exist when it is merged.

@nischaldutt
Copy link
Contributor

I have a problem. When I forked the repository, every file and folder is copied except for the common folder, where I have to commit the changes.

Am I missing something?

@thecodingaviator
Copy link
Contributor

Is the problem still there @moT01 ?

@moT01
Copy link
Member Author

moT01 commented Nov 22, 2018

Yes @thecodingaviator, this problem still persists - you can see it by clicking the link to my profile I put in the issue description, then clicking the full stack cert under the legacy area.

@thecodingaviator
Copy link
Contributor

On a side note, when did you claim the Full Stack Certification?

@thecodingaviator
Copy link
Contributor

Okay, I've figured out the problem, we're using one and the same variable for the legacy and 2018 Full-Stack certs, this is somewhere messing up

@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 21, 2019
@scissorsneedfoodtoo
Copy link
Contributor

I believe #35608 will address this.

@thecodingaviator
Copy link
Contributor

thecodingaviator commented Apr 5, 2019

@scissorsneedfoodtoo I guess so, I'll close my PR.

@ahmadabdolsaheb I'm assigning you to the issue, please have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
6 participants