Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Try to fix Legacy Full Stack Cert not displaying #34424

Closed

Conversation

thecodingaviator
Copy link
Contributor

This PR aims to fix the issue with Legacy Full Stack Certification not displaying, the only thing which I think of can be wrong with my changes is that the order in which the boolean variables to which whether the user has the certificate or not is assigned.

I request someone from the team who has worked on this before maybe @Bouncey can guide me to whether the order is correct or not and if not, what is the correct order.

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #18253

@thecodingaviator thecodingaviator requested a review from a team November 22, 2018 15:18
@thecodingaviator
Copy link
Contributor Author

@nikrb Can you please help me out by checking is the changes I have made do not break down the page and work as intended?

All the certifications should display if the user has it including the Legacy Full Stack cert, and please try turning the 2018 and Legacy Full Stack certs off and on alternatively through the DB so that it is confirmed that the changes work as they should and only the certifications which the user has are displayed.

Thanks in advance!

@ezioda004 ezioda004 added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Nov 27, 2018
@nikrb
Copy link
Member

nikrb commented Dec 20, 2018

waiting for dev login fix #32935 to test this

@nikrb nikrb added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Dec 20, 2018
@thecodingaviator
Copy link
Contributor Author

@nikrb 32935 has closed, could you please check this

@raisedadead raisedadead added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. labels Feb 14, 2019
@thecodingaviator
Copy link
Contributor Author

I'm closing this in favor of #35608 also because I have absolutely no idea what I was trying to do and a more experienced hand would be better off doing this

@thecodingaviator thecodingaviator deleted the patch-32 branch April 5, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue after claiming full stack certificate - legacy full stack shows error
5 participants