fix/add-tests-for-url-shortner-project #37588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
camperbot
added
language: English
scope: curriculum
13 tasks
moT01
requested changes
Mar 18, 2020
There was a problem hiding this comment.
Thanks for the PR @abbathaw.
The tests looks like they work, I'm not sure if we want to be attaching variables to the window object though. What do you think about that @ojeytonwilliams @RandellDawson?
...apis-and-microservices/apis-and-microservices-projects/url-shortener-microservice.english.md
Outdated
Show resolved
Hide resolved
RandellDawson
added
the
status: waiting update
…eeCodeCamp#38756) * Fix `largestPrimeFactor(8)` result * Improve `largestPrimeFactor` performance * Add `largestPrimeFactor(8)` test
* add: test to return early pattern Currently no test for a = 0 or b = 0. This results in if(a<=0 || b<= 0) also being a valid solution * fix: typo in test text * fix: update return early pattern test Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com> Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
…eCamp#38500) * changes to bfs instructions * added description on visual representation * Added to the animation description * Added information about stacks in the description * Edited description for clarity * Edited small details for grammar and clarity * Apply suggested wording and typo fixes Co-authored-by: Eric Leung <eric@erictleung.com> * Add typo fixes to BFS challenge Co-authored-by: Kyla Yujiri <27860923+kylayujiri@users.noreply.github.com> Co-authored-by: Eric Leung <eric@erictleung.com>
Addresses freeCodeCamp#38546 (comment) where it's pointed out that Firefox doesn't support the /s regex flag yet. This workaround matches anything that's not blank.
* Fixed a Typo in Eulers Problem 70 Line 15 should say "Find the value of <var>n</var>, 1 < <var>n</var> < 10**7, for which φ(<var>n</var>) is a permutation of <var>n</var> and the ratio <var>n</var>/φ(<var>n</var>) produces a minimum." instead of Find the value of <var>n</var>, 1 < <var>n</var> < 107, for which φ(<var>n</var>) is a permutation of <var>n</var> and the ratio <var>n</var>/φ(<var>n</var>) produces a minimum. * Updated the Markdown Fixes the markdown to display proper superscript rather than just using ** to denote a superscript
* create fizzbuzz challenge * add lesson to meta file * update testString * fixed changes
Updated and unified workflows for working with various application VMs
* fix(learn): clarify description for finders keepers Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: make mongodb instructions accurate
The old message made it sound like there was a problem with the server, even though no attempt was being made to contact it.
* Disambiguate "Priority Queue" instructions * Add front() to solution * Add tests for front() method * Fix test typo Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* feat: add resources for data analysis videos Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Fixed-pass-an-arrays-props * Fixed:pass-an-array-as-props2 * Update curriculum/challenges/english/03-front-end-libraries/react/pass-an-array-as-props.english.md Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Update curriculum/challenges/english/03-front-end-libraries/react/pass-an-array-as-props.english.md Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Update curriculum/challenges/english/03-front-end-libraries/react/pass-an-array-as-props.english.md Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
…reeCodeCamp#38754) * feat(interview-prep): Converting and Tranfering Rosetta challenges
* delay offline warning * Delayed the offline warning * delayed offline warning * revert unwanted changes * correct spacing * correct spacing second time * use let instead of var
…obally (freeCodeCamp#39296) * feat(gitpod): Add env variables to .profile so they can be accessed globally.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is closed after a git rebase mistake / disaster. New PR is here #39311
Update index.md)masterbranch of freeCodeCamp.Closes #37305
3 of 4 tests have been copied from this location owned by christophrus and I was directed to them as per discussions in #37185.
I went through his tests and found that the example he provided to test the url body using the fcc-backend-tester was good enough to use and merge here.
The 4th test is copied from a comment by @ojeytonwilliams in the same issue above.