Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine step 21 -22 and steps 41 - 42 for cat painting project #54912

Closed
hbar1st opened this issue May 21, 2024 · 4 comments · Fixed by #54917
Closed

Combine step 21 -22 and steps 41 - 42 for cat painting project #54912

hbar1st opened this issue May 21, 2024 · 4 comments · Fixed by #54917
Labels
help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@hbar1st
Copy link
Contributor

hbar1st commented May 21, 2024

Describe the Issue

Steps 21 and 22 of the RWD project to build a cat painting should be combined as they are just asking the learner to add two divs (one to the .cat-left-ear and one to the .cat-right-ear)
Two steps to add 2 divs is unnecessary (this should be easy for learners who've been through all the previous projects)

Affected Page

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-intermediate-css-by-building-a-cat-painting/step-21

Your code




Expected behavior

Instead of a step for each inner ear div, a single step should suffice with instructions similar to:

Create two div elements. First inside .cat-left-ear element with class cat-left-inner-ear, and second inside .cat-right-ear element with class cat-right-inner-ear.

Screenshots

No response

System

N/A

Additional context

No response

@hbar1st hbar1st added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. labels May 21, 2024
@hbar1st
Copy link
Contributor Author

hbar1st commented May 21, 2024

also note, steps 41 and 42 have a similar issue and can be combined as well

@jdwilkin4 jdwilkin4 changed the title RWD build a cat painting projects steps 21 and 22 should be combined Combine step 21 -22 and steps 41 - 42 for cat painting project May 22, 2024
@jdwilkin4 jdwilkin4 added help wanted Open for all. You do not need permission to work on these. and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels May 22, 2024
@jdwilkin4
Copy link
Contributor

jdwilkin4 commented May 22, 2024

Note to contributors

For the updated step 21, this should be the starting seed code to make it clear where campers need to write their code
And of course the instructions and tests will need to be updated to properly merge current step 22 into step 21.
Then delete step 22

        <div class="cat-ears">
          --fcc-editable-region--
          <div class="cat-left-ear">
            
          </div>
          <div class="cat-right-ear">
            
          </div>
          --fcc-editable-region--
        </div>

For the updated step 41, here is the updated seed code to show where the updates need to be made
And of course the instructions and tests will need to be updated to properly merge current step 42 into step 41.
Then delete step 42

        <div class="cat-eyes">
          --fcc-editable-region--
          <div class="cat-left-eye">
            
          </div>
          <div class="cat-right-eye">
            
          </div>
          --fcc-editable-region--
        </div>  

If you are new to removing steps, please read through the docs here
https://contribute.freecodecamp.org/how-to-work-on-practice-projects/#how-to-work-on-practice-projects

@vaibhav-ace
Copy link
Contributor

vaibhav-ace commented May 23, 2024

Hi, I have created a PR for this issue. I hope the PR solves this issue. Please let me know if any changes are required. A complete description of the PR and steps I took to solve the issue are in the PR description. Thanks!

@jdwilkin4 just a query. I was wondering if my PR will be considered since it was generated first in this case?

@cheenu-1824
Copy link
Contributor

@vaibhav-ace, I have looked through your PR and tested locally, the changes look good to me. Code review also looks good with no specific problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
4 participants