-
-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine step 21 -22 and steps 41 - 42 for cat painting project #54912
Comments
also note, steps 41 and 42 have a similar issue and can be combined as well |
Note to contributorsFor the updated step 21, this should be the starting seed code to make it clear where campers need to write their code <div class="cat-ears">
--fcc-editable-region--
<div class="cat-left-ear">
</div>
<div class="cat-right-ear">
</div>
--fcc-editable-region--
</div> For the updated step 41, here is the updated seed code to show where the updates need to be made <div class="cat-eyes">
--fcc-editable-region--
<div class="cat-left-eye">
</div>
<div class="cat-right-eye">
</div>
--fcc-editable-region--
</div> If you are new to removing steps, please read through the docs here |
Hi, I have created a PR for this issue. I hope the PR solves this issue. Please let me know if any changes are required. A complete description of the PR and steps I took to solve the issue are in the PR description. Thanks! @jdwilkin4 just a query. I was wondering if my PR will be considered since it was generated first in this case? |
@vaibhav-ace, I have looked through your PR and tested locally, the changes look good to me. Code review also looks good with no specific problems! |
Describe the Issue
Steps 21 and 22 of the RWD project to build a cat painting should be combined as they are just asking the learner to add two divs (one to the .cat-left-ear and one to the .cat-right-ear)
Two steps to add 2 divs is unnecessary (this should be easy for learners who've been through all the previous projects)
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-intermediate-css-by-building-a-cat-painting/step-21
Your code
Expected behavior
Instead of a step for each inner ear div, a single step should suffice with instructions similar to:
Create two div elements. First inside .cat-left-ear element with class cat-left-inner-ear, and second inside .cat-right-ear element with class cat-right-inner-ear.
Screenshots
No response
System
N/A
Additional context
No response
The text was updated successfully, but these errors were encountered: