Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): Merge similar steps with improved tests #54929

Closed
wants to merge 3 commits into from

Conversation

zxc-w
Copy link
Contributor

@zxc-w zxc-w commented May 22, 2024

Checklist:

Closes #54912


I added one more test case for the second task of each step, as with the original one before merging them, it will accept this:

image

I did it with regex, I tried doing it with a similar way to the first task but it seems that multiple </div> after it is a little confusing for the test.
I tried many other ways and the regex is the only one that worked for me.

Let me know if there is anything I did wrong or can be done in a better way.

@zxc-w zxc-w requested a review from a team as a code owner May 22, 2024 22:02
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels May 22, 2024
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 22, 2024
@huyenltnguyen huyenltnguyen added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label May 23, 2024
@camperbot
Copy link
Contributor

We would love to be able to merge your changes, but it looks like you have some merge conflicts. ⚠️

Once you resolve these conflicts, we will be able to review you rPR and merge it. 😊


If you're not familiar with the merge conflict process, feel free to look over GitHub's guide on "Resolving a merge conflict". 🔍️

Also, it's good practice on GitHub to write a brief description of your changes when creating a PR. 📝

@jdwilkin4 jdwilkin4 removed their assignment May 23, 2024
@huyenltnguyen huyenltnguyen added status: merge conflict To be applied to PR's that have a merge conflict and need updating status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: merge conflict To be applied to PR's that have a merge conflict and need updating status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 23, 2024
@moT01 moT01 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP status: merge conflict To be applied to PR's that have a merge conflict and need updating labels May 24, 2024
@naomi-lgbt
Copy link
Member

Thanks for your interest in contributing! We have accepted an earlier contribution which resolves the same issue. Please don't feel discouraged - we look forward to seeing future contributions from you. 💜

@naomi-lgbt naomi-lgbt closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine step 21 -22 and steps 41 - 42 for cat painting project
7 participants