-
-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (curriculum): added functionality to merge steps 21 - 22 and steps 41 - 42 #54917
fix (curriculum): added functionality to merge steps 21 - 22 and steps 41 - 42 #54917
Conversation
Thanks for your pull request. Please remove the changes made to the non-English versions of the files. No need to close this pull request; just add more commits as needed. We require you to change only English versions of files in the codebase. Translations to corresponding files in other world languages are managed on our translation platform. Once your pull request is merged, changes will be synced automatically to other world languages. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources. As always, we value all of your contributions. Happy contributing! Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat. |
691795b
to
4de9b33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work, you are doing well!
I have left some comments on things to change
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ce9d790d2a44de5f99e04.md
Outdated
Show resolved
Hide resolved
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ce9d790d2a44de5f99e04.md
Outdated
Show resolved
Hide resolved
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ce9d790d2a44de5f99e04.md
Outdated
Show resolved
Hide resolved
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ddd3f9f97a0667b964bdb.md
Outdated
Show resolved
Hide resolved
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ddd3f9f97a0667b964bdb.md
Outdated
Show resolved
Hide resolved
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ddd3f9f97a0667b964bdb.md
Outdated
Show resolved
Hide resolved
Thanks for your pull request. Please remove the changes made to the non-English versions of the files. No need to close this pull request; just add more commits as needed. We require you to change only English versions of files in the codebase. Translations to corresponding files in other world languages are managed on our translation platform. Once your pull request is merged, changes will be synced automatically to other world languages. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources. As always, we value all of your contributions. Happy contributing! Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat. |
7297351
to
fa709ca
Compare
Thanks a lot for the review and feedback. I highly appreciate the help as I try and get better in my contributions 🙏 I have made the necessary changes and hope they suffice the conditions for a merge. Please let me know if any further changes are required, I will be more than happy to work on them. 😄 |
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ce9d790d2a44de5f99e04.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going well, the new hints require some adjustments!
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ce9d790d2a44de5f99e04.md
Outdated
Show resolved
Hide resolved
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ce9d790d2a44de5f99e04.md
Outdated
Show resolved
Hide resolved
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ce9d790d2a44de5f99e04.md
Outdated
Show resolved
Hide resolved
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ce9d790d2a44de5f99e04.md
Outdated
Show resolved
Hide resolved
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ddd3f9f97a0667b964bdb.md
Outdated
Show resolved
Hide resolved
...-web-design-22/learn-intermediate-css-by-building-a-cat-painting/646ddd3f9f97a0667b964bdb.md
Outdated
Show resolved
Hide resolved
Thanks for the suggestions. I've changed the code as per the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Checklist:
main
branch of freeCodeCamp.Closes #54912
PR Description
This PR combines Steps 21 and 22 of the Responsive Web Design project to build a cat painting into a single step. The updated step now instructs learners to create two div elements, one inside the
.cat-left-ear
element with theclass cat-left-inner-ear
and another inside the.cat-right-ear element
with the classcat-right-inner-ear
.Then using the doc guide at: https://contribute.freecodecamp.org/how-to-work-on-practice-projects/#how-to-work-on-practice-projects
I have delete step 22.
Moving on, I have combined Steps 41 and 42 of the Responsive Web Design project as well in this PR according to the comments mentioned in the original thread.
Note: The updated steps were 40 and 41 when changes were made to them (due to deletion of step 22).
Following on, I deleted the updated step 41 to ensure that duplication is removed from the codebase.
All tests were also updated for the combined steps.
All changes have been tested locally to ensure the instructions work as expected and do not disrupt the learning flow.
Step 21 after update:
Step 40 after update: