-
-
Notifications
You must be signed in to change notification settings - Fork 37.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add project euler problems #14605
Feature/add project euler problems #14605
Conversation
Notes: This is a rough draft to get everyone started. * Questions for which I did not have confirmed answers for have "TODO" marked in the tests. * Some descriptions contain latex - I scraped them off the official project euler site (where they use MathJax) * Some descriptions contain images - easily found in the json by looking for contiguous blank lines - these will have to be handled manually.
Scraped first 600 Project Euler Problems
@P1xt thanks for the PR. |
There is zero chance I'm squashing commits on this, I only had one commit but it was based off a branch @QuincyLarson created. |
@P1xt thanks for the pull request, There are a lot of un-encoded values in the json, which would be an issue, please reformat things like :
Also I am afraid you have to squash this because the PR does have 2 commits and you would possibly be editing the json for fixes. Also I believe that you can choose to do so this via multiple smaller PRs to make it easier for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff is too long for review comments if possible please break into smaller pull requests.
@raisedadead This is fine for now. I've gone through and spot-checked it. It doesn't seem to be breaking the build - the JSON seems valid. This is a work in progress. I'm going to go ahead and merge it in. |
I've gone through and spot-checked it. It doesn't seem to be breaking the build - the JSON seems valid. This is a work in progress.
Notes: This is a rough draft to get everyone started. * Questions for which I did not have confirmed answers for have "TODO" marked in the tests. * Some descriptions contain latex - I scraped them off the official project euler site (where they use MathJax) * Some descriptions contain images - easily found in the json by looking for contiguous blank lines - these will have to be handled manually.
Notes: This is a rough draft to get everyone started. * Questions for which I did not have confirmed answers for have "TODO" marked in the tests. * Some descriptions contain latex - I scraped them off the official project euler site (where they use MathJax) * Some descriptions contain images - easily found in the json by looking for contiguous blank lines - these will have to be handled manually.
@QuincyLarson
@AdventureBear
Here's the bulk load json for the Project Euler stuff. It may or may not need to be resubmitted. I won't be resubmitting it but either of you are free to.
I ran a quick scrape of Project Euler to fill out the bulk of what will be needed for the add-project-euler-problems feature
The json contains all 600 existing questions, including a test against a confirmed correct answer for each question for which a confirmed answer is available. There is still more work to be done, but this should handle the initial bulk load.