Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add project euler problems #14605

Merged
merged 2 commits into from
May 3, 2017
Merged

Feature/add project euler problems #14605

merged 2 commits into from
May 3, 2017

Conversation

P1xt
Copy link
Contributor

@P1xt P1xt commented Apr 26, 2017

@QuincyLarson
@AdventureBear

Here's the bulk load json for the Project Euler stuff. It may or may not need to be resubmitted. I won't be resubmitting it but either of you are free to.

I ran a quick scrape of Project Euler to fill out the bulk of what will be needed for the add-project-euler-problems feature

The json contains all 600 existing questions, including a test against a confirmed correct answer for each question for which a confirmed answer is available. There is still more work to be done, but this should handle the initial bulk load.

  • Questions for which I did not have confirmed answers for have "TODO" marked in the tests.
  • Some descriptions contain latex - I scraped them off the official project euler site (where they use MathJax)
  • Some descriptions contain images - easily found in the json by looking for contiguous blank lines - these will have to be handled manually.

Notes:

This is a rough draft to get everyone started.

* Questions for which I did not have confirmed answers for have "TODO" marked in the tests.
* Some descriptions contain latex - I scraped them off the official project euler site (where they use MathJax)
* Some descriptions contain images - easily found in the json by looking for contiguous blank lines - these will have to be handled manually.
@camperbot
Copy link
Contributor

@P1xt thanks for the PR.
You have pushed more than one commit. When you finish editing, squash your commits into one.
Please, review our Guidelines for Contributing, thank you!.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 26, 2017
@P1xt
Copy link
Contributor Author

P1xt commented Apr 26, 2017

There is zero chance I'm squashing commits on this, I only had one commit but it was based off a branch @QuincyLarson created.

@raisedadead
Copy link
Member

@P1xt thanks for the pull request,

There are a lot of un-encoded values in the json, which would be an issue, please reformat things like :

\u003c

Also I am afraid you have to squash this because the PR does have 2 commits and you would possibly be editing the json for fixes.

Also I believe that you can choose to do so this via multiple smaller PRs to make it easier for you?
Thanks.

Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is too long for review comments if possible please break into smaller pull requests.

@raisedadead raisedadead added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Apr 27, 2017
@QuincyLarson
Copy link
Contributor

@raisedadead This is fine for now. I've gone through and spot-checked it. It doesn't seem to be breaking the build - the JSON seems valid.

This is a work in progress. I'm going to go ahead and merge it in.

@QuincyLarson QuincyLarson dismissed raisedadead’s stale review May 3, 2017 19:52

I've gone through and spot-checked it. It doesn't seem to be breaking the build - the JSON seems valid. This is a work in progress.

@QuincyLarson QuincyLarson merged commit 2ceb75e into freeCodeCamp:feature/add-project-euler-problems May 3, 2017
@QuincyLarson QuincyLarson removed status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 3, 2017
QuincyLarson pushed a commit to QuincyLarson/freecodecamp that referenced this pull request May 3, 2017
Notes:

This is a rough draft to get everyone started.

* Questions for which I did not have confirmed answers for have "TODO" marked in the tests.
* Some descriptions contain latex - I scraped them off the official project euler site (where they use MathJax)
* Some descriptions contain images - easily found in the json by looking for contiguous blank lines - these will have to be handled manually.
@P1xt P1xt deleted the feature/add-project-euler-problems branch May 3, 2017 22:55
mhatout pushed a commit to mhatout/freeCodeCamp that referenced this pull request Feb 9, 2018
Notes:

This is a rough draft to get everyone started.

* Questions for which I did not have confirmed answers for have "TODO" marked in the tests.
* Some descriptions contain latex - I scraped them off the official project euler site (where they use MathJax)
* Some descriptions contain images - easily found in the json by looking for contiguous blank lines - these will have to be handled manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants