Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(LoopBack): Upgrade to LoopBack 3 #15103

Closed
wants to merge 7 commits into from
Closed

chore(LoopBack): Upgrade to LoopBack 3 #15103

wants to merge 7 commits into from

Conversation

raisedadead
Copy link
Member

@raisedadead raisedadead commented May 28, 2017

This upgrades LoopBack to v3.x.x

  • Update LoopBack version
  • Update use of REST error handler
  • Replace LoopBack middleware “getter” properties
  • Update models
  • Update models derived from PersistedModel
  • Explicitly add User model properties that were removed
  • Remove use of current-context methods, middleware, and configuration settings
    • This throws an error, please see the linked gist below for details.
  • Check request parameter encoding
  • Update use of promises
  • Check CORS configuration

More details of the checklist with some error stack are available here:
https://gist.github.com/raisedadead/22f7a38bb47204fded9b0877fde954ef

Closes #12780

@raisedadead raisedadead added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 28, 2017
@raisedadead raisedadead added status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 31, 2017
@camperbot
Copy link
Contributor

@raisedadead updated the pull request.

2 similar comments
@camperbot
Copy link
Contributor

@raisedadead updated the pull request.

@camperbot
Copy link
Contributor

@raisedadead updated the pull request.

@camperbot
Copy link
Contributor

@raisedadead updated the pull request.

@systimotic
Copy link
Member

@raisedadead Is this still blocked?

@BerkeleyTrue BerkeleyTrue removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Sep 2, 2017
@raisedadead
Copy link
Member Author

Hi @systimotic I was away for a bit, I could still continue, but looks like this is closed. I'll let @BerkeleyTrue confirm if there are other plans before I continue.

Cheers.

@systimotic
Copy link
Member

@raisedadead 👍 No worries. I'm pretty sure this was closed as stale, as a part of the massive cleanup. If you want to update this / get it reviewed, I think you're free to reopen it.

@raisedadead
Copy link
Member Author

Sure, I just got whats going on... lol. Thanks for the link. I'll make a fresh pull request (I have to update the code anyways) because we need this upgrade

@systimotic
Copy link
Member

@raisedadead Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants