fix(email): Check unquiness of email #15205

raisedadead · 2017-06-04T15:54:28Z

This should let us check for uniqueness of email when the user attributes are updated via the API.

I have back-ported some utils from feat(auth): Implement Passwordless Authentication #9660
Tested this with a duplicate user instance and reset password logic, which is the most cited area of this issue.

raisedadead · 2017-06-04T15:59:56Z

Note: I have although left the error message display to a raw message returned from loopback, this is done intentionally because the entire reset logic is going away in any case with passwordless.

@BerkeleyTrue:
Also, any users already duplicated will be affected. To find out we should do some backend purging or notifications to such users.

raisedadead · 2017-06-04T16:00:16Z

Also do we need this on production?

camperbot · 2017-06-04T16:12:41Z

@raisedadead updated the pull request.

common/models/user.js

+  // see:
+  // https://github.com/strongloop/loopback/issues/1137#issuecomment-271437926
+  User.validate('email', function( err ) {
+    if ( this.email && !isEmail(this.email)) {


BerkeleyTrue · 2017-06-11T19:55:21Z

@raisedadead We originally removed the email check because we only allowed third party sign ups, and that resulted in only having usernames as unique to everyone.

Since we are now moving to email first validation, should we just remove the email validation deletion?

camperbot · 2017-06-11T21:50:39Z

@raisedadead updated the pull request.

raisedadead · 2017-06-11T21:53:09Z

@BerkeleyTrue Excellent point, yes we should do that when we remove GitHub auth completely (maybe after passwordless goes in).

Until then this is we would still need this (as we are still creating user accounts, with GitHub)

BerkeleyTrue · 2017-06-11T23:13:52Z

Ok, then an addition to passwordless would be to remove the ability to create accounts with github and re-add the original email validations.

raisedadead · 2017-06-12T14:34:45Z

@BerkeleyTrue Yes, that is correct and #10407 should address this.

I have updated the user stories so that this is tracked there.

common/models/user.js

+  // Updated workaround for email validation
+  // see:
+  // https://github.com/strongloop/loopback/issues/1137#issuecomment-271437926
+  User.validate('email', function( err ) {


common/models/user.js

+  // https://github.com/strongloop/loopback/issues/1137#issuecomment-271437926
+  User.validate('email', function( err ) {
+    if (this.email && !isEmail(this.email)) {
+      debug(err);


common/models/user.js

+      debug(err);
+    }
+  }, {
+    message: 'Email format is invalid, please check again'


camperbot · 2017-07-07T07:02:30Z

@raisedadead updated the pull request.

raisedadead · 2017-07-07T07:12:50Z

Just confirming again, do we need this on production?

camperbot · 2017-07-13T19:03:25Z

@raisedadead updated the pull request.

camperbot · 2017-07-13T19:17:22Z

@raisedadead updated the pull request.

server/boot/user.js

@@ -608,7 +608,14 @@ module.exports = function(app) {
    return User.findById(req.accessToken.userId, function(err, user) {
      if (err) { return next(err); }
      return user.updateAttribute('password', password, function(err) {
-        if (err) { return next(err); }
+        if (err) {


server/boot/user.js

+        if (err) {
+          debug(err);
+          req.flash('error', {
+            msg: err.message ||


common/models/user.js

+    if (this.email && !isEmail(this.email)) {
+      // Here err is a callback
+      // See loopback api docs loopback-datasource-juggler/#validatable-validate
+      debug(err());


raisedadead added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 4, 2017

raisedadead requested a review from BerkeleyTrue June 4, 2017 15:59

BerkeleyTrue reviewed Jun 11, 2017

View reviewed changes

common/models/user.js Outdated

// see:

// https://github.com/strongloop/loopback/issues/1137#issuecomment-271437926

User.validate('email', function( err ) {

if ( this.email && !isEmail(this.email)) {

This comment was marked as off-topic.

Sign in to view

QuincyLarson mentioned this pull request Jun 12, 2017

Remove ability to create a new FCC account using GitHub #10407

Closed

4 tasks

BerkeleyTrue suggested changes Jul 5, 2017

View reviewed changes

common/models/user.js Outdated

// Updated workaround for email validation

// see:

// https://github.com/strongloop/loopback/issues/1137#issuecomment-271437926

User.validate('email', function( err ) {

This comment was marked as off-topic.

Sign in to view

BerkeleyTrue suggested changes Jul 5, 2017

View reviewed changes

raisedadead mentioned this pull request Jul 10, 2017

[beta] Progress lost on beta.freeCodeCamp.com #13462

Closed

fix(email): check unquiness of email

3f79222

BerkeleyTrue reviewed Jul 13, 2017

View reviewed changes

server/boot/user.js

if (err) {

debug(err);

req.flash('error', {

msg: err.message ||

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

BerkeleyTrue reviewed Jul 13, 2017

View reviewed changes

raisedadead added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Jul 13, 2017

BerkeleyTrue closed this Sep 2, 2017

BerkeleyTrue removed status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Sep 2, 2017

raisedadead deleted the fix/unique-email-validation branch September 2, 2017 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(email): Check unquiness of email #15205

fix(email): Check unquiness of email #15205

raisedadead commented Jun 4, 2017 •

edited

Loading

raisedadead commented Jun 4, 2017

raisedadead commented Jun 4, 2017

camperbot commented Jun 4, 2017

This comment was marked as off-topic.

BerkeleyTrue commented Jun 11, 2017

camperbot commented Jun 11, 2017

raisedadead commented Jun 11, 2017

BerkeleyTrue commented Jun 11, 2017

raisedadead commented Jun 12, 2017

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

camperbot commented Jul 7, 2017

raisedadead commented Jul 7, 2017

camperbot commented Jul 13, 2017

camperbot commented Jul 13, 2017

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

fix(email): Check unquiness of email #15205

fix(email): Check unquiness of email #15205

Conversation

raisedadead commented Jun 4, 2017 • edited Loading

raisedadead commented Jun 4, 2017

raisedadead commented Jun 4, 2017

camperbot commented Jun 4, 2017

This comment was marked as off-topic.

BerkeleyTrue commented Jun 11, 2017

camperbot commented Jun 11, 2017

raisedadead commented Jun 11, 2017

BerkeleyTrue commented Jun 11, 2017

raisedadead commented Jun 12, 2017

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

camperbot commented Jul 7, 2017

raisedadead commented Jul 7, 2017

camperbot commented Jul 13, 2017

camperbot commented Jul 13, 2017

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

raisedadead commented Jun 4, 2017 •

edited

Loading