Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified the sort function #25978

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Modified the sort function #25978

merged 1 commit into from
Oct 22, 2018

Conversation

utkarsh-raj
Copy link
Contributor

Modification in the sort function to implement the better practice of returning 0 for the same elements. Not implementing the practice can break the function in new browsers.

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #25829

@utkarsh-raj
Modified the sort function
851c1ae 
Modification in the sort function to implement the better practice of returning 0 for the same elements. Not implementing the practice can break the function in new browsers.
@ezioda004 ezioda004 self-assigned this Oct 22, 2018
@ezioda004 ezioda004 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Oct 22, 2018
Nirajn2311
Nirajn2311 approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@Nirajn2311 Nirajn2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍 and Congrats on your first PR 🎉 🎉

@ezioda004 ezioda004 merged commit 02206a2 into freeCodeCamp:master Oct 22, 2018
@ezioda004
Copy link
Contributor

Thank you @utkarsh-raj for your contribution and congratulations on your first PR merge to this repo! 🎉

@Amjadamjad Amjadamjad mentioned this pull request Oct 23, 2018
Closed
vdkhadke pushed a commit to vdkhadke/freeCodeCamp that referenced this pull request Oct 28, 2018
@utkarsh-raj @vdkhadke
Modified the sort function (freeCodeCamp#25978)
e412df4 
Modification in the sort function to implement the better practice of returning 0 for the same elements. Not implementing the practice can break the function in new browsers.
@ezioda004 ezioda004 mentioned this pull request Dec 5, 2018
Closed
@lasjorg lasjorg mentioned this pull request Dec 21, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezioda004 ezioda004 ezioda004 approved these changes

@Nirajn2311 Nirajn2311 Nirajn2311 approved these changes

Assignees

@ezioda004 ezioda004

Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update text in Sort an Array Alphabetically using the sort Method Challenge
3 participants
@utkarsh-raj @ezioda004 @Nirajn2311