Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test to determine num of elements with class #3361

Merged
merged 1 commit into from
Sep 19, 2015
Merged

Added test to determine num of elements with class #3361

merged 1 commit into from
Sep 19, 2015

Conversation

anrddh
Copy link
Member

@anrddh anrddh commented Sep 19, 2015

Closes #1762

Apologies for the oversight.

@dcsan dcsan added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 19, 2015
@bugron
Copy link
Contributor

bugron commented Sep 19, 2015

@awesomeaniruddh not sure why there are two single quotes at the end of "assert($(\"p.red-text\").length === 2, 'Give each of your <code>p</code> elements the <code>red-text</code> class.'')",? This causes an error.
Also I want to discuss thes.

"Give the elements with the red-text class the font-size of 16px." seems there is an extra the (or two), but I'm not sure at this point.

@anrddh
Copy link
Member Author

anrddh commented Sep 19, 2015

^ Fixed the thes. Seems like me text editor did that. Let me fix it. Phew.

@anrddh
Copy link
Member Author

anrddh commented Sep 19, 2015

Yep, done.

@bugron
Copy link
Contributor

bugron commented Sep 19, 2015

@awesomeaniruddh Excellent, verified and merged, thanks for the PR!

bugron added a commit that referenced this pull request Sep 19, 2015
Added test to determine num of elements with class
@bugron bugron merged commit 2d6df96 into freeCodeCamp:staging Sep 19, 2015
@bugron bugron removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 19, 2015
@anrddh anrddh deleted the fix/html-permissive-test branch September 25, 2015 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants