Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added solution to make typography responsive challenge #34289

Merged
merged 2 commits into from
Mar 9, 2019
Merged

Added solution to make typography responsive challenge #34289

merged 2 commits into from
Mar 9, 2019

Conversation

thecodingaviator
Copy link
Contributor

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

@thecodingaviator
Copy link
Contributor Author

Closed/reopened to clear Travis CI error

RandellDawson
RandellDawson suggested changes Mar 8, 2019
View reviewed changes
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your hints look great, but please add the following so the solution includes all of the original seed code plus the style CSS properties needed.

@RandellDawson RandellDawson added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Mar 8, 2019
@thecodingaviator
Copy link
Contributor Author

@RandellDawson I will, soon. I’ll also update my other PRs from around the same time having incomplete solutions

@thecodingaviator
Copy link
Contributor Author

Full solution added

@RandellDawson RandellDawson removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Mar 9, 2019
RandellDawson
RandellDawson approved these changes Mar 9, 2019
View reviewed changes
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. LGTM

@RandellDawson RandellDawson merged commit ddf2c99 into freeCodeCamp:master Mar 9, 2019
@RandellDawson
Copy link
Member

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉

@thecodingaviator thecodingaviator deleted the patch-17 branch March 9, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandellDawson RandellDawson RandellDawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thecodingaviator @RandellDawson @camperbot