Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guide): removed guide set-related articles no longer needed #35679

Conversation

RandellDawson
Copy link
Member

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Since PR #34717 was merged recently which combined three set-related curriculum challenges into one, the following challenge files were deleted:

curriculum/challenges/english/08-coding-interview-prep/data-structures/remove-from-a-set.english.md
curriculum/challenges/english/08-coding-interview-prep/data-structures/size-of-the-set.english.md

This PR removes the corresponding Guide articles related to the deleted challenges.

guide/english/certifications/coding-interview-prep/data-structures/remove-from-a-set/index.md
guide/english/certifications/coding-interview-prep/data-structures/size-of-the-set/index.md

@RandellDawson
Copy link
Member Author

Attention Reviewers: This PR can not be merged before #34946, because it deletes files which are on that PR and would cause a merge conflict.

@RandellDawson RandellDawson force-pushed the fix/remove-set-challenge-guide-articles-no-longer-needed branch from a14b371 to a840dd8 Compare April 8, 2019 17:37
@RandellDawson
Copy link
Member Author

#34946 has been merged, so this one can be safely merged once approved.

Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @RandellDawson! 🎉

@moT01 moT01 merged commit 1b07106 into freeCodeCamp:master May 9, 2019
@RandellDawson RandellDawson deleted the fix/remove-set-challenge-guide-articles-no-longer-needed branch May 9, 2019 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants