fix: replace imgur to s3 for various files without conflict #36057
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ localeTitle: 问题15：格子路径 | |
| --- | ||
|
|
||
| ## Description | ||
| <section id="description">从2×2网格的左上角开始，只能向右和向下移动，右下角有6条路线。 <img class="img-responsive center-block" alt="6 2乘2网格的图表显示了右下角的所有路线" src="https://cdn-media-1.freecodecamp.org/imgr/1Atixoj.gif"><p>通过给定的<code>gridSize</code>有多少这样的路由？ </p></section> | ||
|
|
||
| ## Instructions | ||
| <section id="instructions"> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,7 +12,7 @@ One way to add texture and interest to a background and have it stand out more i | |||||
|
|
||||||
| ## Instructions | ||||||
| <section id='instructions'> | ||||||
| Using the url of <code>https://cdn-media-1.freecodecamp.org/imgr/MJAkxbh.png</code>, set the <code>background</code> of the whole page with the <code>body</code> selector. | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| </section> | ||||||
|
|
||||||
| ## Tests | ||||||
|
|
@@ -21,7 +21,7 @@ Using the url of <code>https://i.imgur.com/MJAkxbh.png</code>, set the <code>bac | |||||
| ```yml | ||||||
| tests: | ||||||
| - text: Your <code>body</code> element should have a <code>background</code> property set to a <code>url()</code> with the given link. | ||||||
| testString: assert(code.match(/background:\s*?url\(\s*("|'|)https:\/\/cdn-media-1\.freecodecamp\.org\/imgr\/MJAkxbh\.png\1\s*\)/gi), 'Your <code>body</code> element should have a <code>background</code> property set to a <code>url()</code> with the given link.'); | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| ``` | ||||||
|
|
||||||
|
|
@@ -52,7 +52,7 @@ tests: | |||||
| ```html | ||||||
| <style> | ||||||
| body { | ||||||
| background: url("https://cdn-media-1.freecodecamp.org/imgr/MJAkxbh.png"); | ||||||
|
There was a problem hiding this comment. Do we need to change this, I believe we can just enter any URL there, the current one does not even make sense as a BG. We'll need to update all languages' files There was a problem hiding this comment. I think it's fine as is. The URL does have to be an image for the camper to see a change. Also, this image does create the subtle change that the instructions talk about. There was a problem hiding this comment. @thecodingaviator, thanks for the catch. If it is alright with you, I would rather differ content modifications specially in the curriculum to another PR since it would require a further discussion. There was a problem hiding this comment. Since we're doing it to the Egnlish file, we'll need to do it to the other languages too. If you want to do it in this PR, fine enough, I'm totally fine if you want another file There was a problem hiding this comment. Thank you @thecodingaviator, I took note of suggestions, and I will address them in a separate PR. There was a problem hiding this comment. If everything else other than changing the background look acceptable, please feel free to merge this PR. |
||||||
| } | ||||||
| </style> | ||||||
| ``` | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ videoUrl: 'https://scrimba.com/c/c9bQEA4' | |
| ## Description | ||
| <section id='description'> | ||
| The CSS offsets of <code>top</code> or <code>bottom</code>, and <code>left</code> or <code>right</code> tell the browser how far to offset an item relative to where it would sit in the normal flow of the document. You're offsetting an element away from a given spot, which moves the element away from the referenced side (effectively, the opposite direction). As you saw in the last challenge, using the top offset moved the <code>h2</code> downwards. Likewise, using a left offset moves an item to the right. | ||
| <img src='https://cdn-media-1.freecodecamp.org/imgr/eWWi3gZ.gif' alt='' /> | ||
| </section> | ||
|
|
||
| ## Instructions | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ title: 'Problem 15: Lattice paths' | |
| <section id='description'> | ||
| Starting in the top left corner of a 2×2 grid, and only being able to move to the right and down, there are exactly 6 routes to the bottom right corner. | ||
|
|
||
| <img class="img-responsive center-block" alt="a diagram of 6 2 by 2 grids showing all the routes to the bottom right corner" src="https://cdn-media-1.freecodecamp.org/imgr/1Atixoj.gif"> | ||
|
|
||
| How many such routes are there through a given <code>gridSize</code>? | ||
| </section> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,15 +10,15 @@ localeTitle: Criar textura adicionando um padrão sutil como imagem de plano de | |||||
| <section id="description"> Uma maneira de adicionar textura e interesse a um plano de fundo e destacá-lo é adicionar um padrão sutil. A chave é o equilíbrio, já que você não quer que o fundo se destaque muito e tire o primeiro plano. A propriedade <code>background</code> suporta a função <code>url()</code> para vincular a uma imagem da textura ou padrão escolhido. O endereço do link é colocado entre aspas entre parênteses. </section> | ||||||
|
|
||||||
| ## Instructions | ||||||
| <section id="instructions"> Usando o url de <code>https://cdn-media-1.freecodecamp.org/imgr/MJAkxbh.png</code> , defina o <code>background</code> de toda a página com o seletor de <code>body</code> . </section> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| ## Tests | ||||||
| <section id='tests'> | ||||||
|
|
||||||
| ```yml | ||||||
| tests: | ||||||
| - text: Seu elemento <code>body</code> deve ter uma propriedade <code>background</code> definida como <code>url()</code> com o link fornecido. | ||||||
| testString: 'assert(code.match(/background:\s*?url\(\s*("|"|)https:\/\/cdn-media-1\.freecodecamp\.org\/imgr\/MJAkxbh\.png\1\s*\)/gi), "Your <code>body</code> element should have a <code>background</code> property set to a <code>url()</code> with the given link.");' | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| ``` | ||||||
|
|
||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ localeTitle: 'Problema 15: caminhos da rede' | |
| --- | ||
|
|
||
| ## Description | ||
| <section id="description"> Começando no canto superior esquerdo de uma grade de 2 × 2, e somente sendo capaz de se mover para a direita e para baixo, há exatamente 6 rotas para o canto inferior direito. <img class="img-responsive center-block" alt="um diagrama de 6 2 por 2 grades mostrando todas as rotas para o canto inferior direito" src="https://cdn-media-1.freecodecamp.org/imgr/1Atixoj.gif"><p> Quantas dessas rotas estão lá através de um determinado <code>gridSize</code> ? </p></section> | ||
|
|
||
| ## Instructions | ||
| <section id="instructions"> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,15 +10,15 @@ localeTitle: Crear textura agregando un patrón sutil como imagen de fondo | |||||
| <section id="description"> Una forma de agregar textura e interés a un fondo y hacer que se destaque más es agregar un patrón sutil. La clave es el equilibrio, ya que no desea que el fondo se destaque demasiado y quita el primer plano. La propiedad de <code>background</code> compatible con la función <code>url()</code> para enlazar a una imagen de la textura o patrón elegido. La dirección del enlace está entre comillas dentro de los paréntesis. </section> | ||||||
|
|
||||||
| ## Instructions | ||||||
| <section id="instructions"> Usando la url de <code>https://cdn-media-1.freecodecamp.org/imgr/MJAkxbh.png</code> , establezca el <code>background</code> de toda la página con el selector de <code>body</code> . </section> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| ## Tests | ||||||
| <section id='tests'> | ||||||
|
|
||||||
| ```yml | ||||||
| tests: | ||||||
| - text: El elemento del <code>body</code> debe tener una propiedad de <code>background</code> establecida en una <code>url()</code> con el enlace dado. | ||||||
| testString: 'assert(code.match(/background:\s*?url\(\s*("|"|)https:\/\/cdn-media-1\.freecodecamp\.org\/imgr\/MJAkxbh\.png\1\s*\)/gi), "Your <code>body</code> element should have a <code>background</code> property set to a <code>url()</code> with the given link.");' | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| ``` | ||||||
|
|
||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ localeTitle: 'Problema 15: caminos de celosía' | |
| --- | ||
|
|
||
| ## Description | ||
| <section id="description"> Comenzando en la esquina superior izquierda de una cuadrícula de 2 × 2, y solo pudiendo moverse hacia la derecha y hacia abajo, hay exactamente 6 rutas hacia la esquina inferior derecha. <img class="img-responsive center-block" alt="un diagrama de 6 cuadrículas de 2 por 2 que muestra todas las rutas hacia la esquina inferior derecha" src="https://cdn-media-1.freecodecamp.org/imgr/1Atixoj.gif"><p> ¿Cuántas de estas rutas hay a través de un <code>gridSize</code> dado? </p></section> | ||
|
|
||
| ## Instructions | ||
| <section id="instructions"> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ title: Difference between Git and GitHub | |
|
|
||
| Git and GitHub are two different things. [Git](https://git-scm.com/) is the [version control system](https://en.wikipedia.org/wiki/Version_control), while [GitHub](https://github.com/) is a service for hosting Git repos and help people collaborate on writing software. However, they are often confounded because of their similar name, because of the fact that GitHub builds on top of Git, and because many websites and articles don't make the difference between them clear enough. | ||
|
|
||
|  | ||
|
|
||
| ### Git | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ Layouts organize different areas of the web page. | |
|
|
||
| Almost every web page we see can be divided into boxes, that can be arranged into specific order to create that web page. The image below is one such example. | ||
|
|
||
|  | ||
|
|
||
| > Websites often display content in multiple columns (like a magazine or newspaper). | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.