Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make donate modal scrollable #36761

Merged

Conversation

moT01
Copy link
Member

@moT01 moT01 commented Sep 5, 2019

I'm not quite sure what you all had in mind for this @raisedadead - but this seems like a quick and easy fix to the scrolling issue - which allows you to get to the close button.

Also, the close button text was underlined - so I got rid of that.

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #36756

@moT01 moT01 requested a review from a team September 5, 2019 22:47
@gitpod-io
Copy link

gitpod-io bot commented Sep 5, 2019

@raisedadead

This comment has been minimized.

@raisedadead raisedadead added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. release: next/beta scope: UI Threads for addressing UX changes and improvements to user interface labels Sep 6, 2019
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Ignore previous comments

@raisedadead
Copy link
Member

@ahmadabdolsaheb will you be adding the changes like we discussed?

@ahmaxed
Copy link
Member

ahmaxed commented Sep 6, 2019

screenshot

image

@raisedadead raisedadead merged commit 338234d into freeCodeCamp:master Sep 6, 2019
@moT01 moT01 deleted the fix/make-donate-modal-closable branch September 7, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to close donate modal
3 participants