Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(i18n,client): enable certs #41789

Merged
merged 1 commit into from
Apr 10, 2021
Merged

feat(i18n,client): enable certs #41789

merged 1 commit into from
Apr 10, 2021

Conversation

naomi-lgbt
Copy link
Member

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

I believe @ojeytonwilliams resolved the issue regarding testing i18n certifications, correct?

This PR enables the next two certs in Chinese at @miyaliu666's request. 🙂

feat(i18n,client): enable certs
ef2a184 
Enable the next two certs in Chinese.
@naomi-lgbt naomi-lgbt requested a review from a team as a code owner April 10, 2021 05:55
@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Apr 10, 2021
@ojeytonwilliams
Copy link
Contributor

That's right. CI should cover the certifications enabled by this PR.

@raisedadead raisedadead enabled auto-merge (squash) April 10, 2021 13:17
@raisedadead raisedadead merged commit 74f2f34 into freeCodeCamp:main Apr 10, 2021
ojeytonwilliams
ojeytonwilliams approved these changes Apr 10, 2021
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@naomi-lgbt naomi-lgbt deleted the feat/enable-certs branch September 16, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raisedadead raisedadead raisedadead approved these changes

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

Assignees
No one assigned
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naomi-lgbt @ojeytonwilliams @raisedadead