feat: css magazine #43507

naomi-lgbt · 2021-09-20T21:20:55Z

Checklist:

I have read freeCodeCamp's contribution guidelines.
My pull request has a descriptive title (not a vague title like Update index.md)
My pull request targets the main branch of freeCodeCamp.
I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Here's the steps. Tests coming soon:tm:

gitpod-io · 2021-09-20T21:21:59Z

gikf

Up to part 40 only thing that was visible in the preview, without scrolling it, was logo. I'd consider moving part with resizing it to some earlier part.

Small findings from completing project below.

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-020.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-021.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-022.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-069.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-001.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-004.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-005.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-024.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-025.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-030.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-031.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-034.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-041.md

scissorsneedfoodtoo

Hey @nhcarrigan, sorry for just a partial review. Everything is looking great so far! Should be a fun project. Lots of great tests and hints throughout, too.

I noticed some things going through and left them as review comments.

I'll finish going through the rest of project ASAP.

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-002.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-003.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-006.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-007.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-009.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-010.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-011.md

scissorsneedfoodtoo

Again, this is looking great @nhcarrigan. I had a ton of fun going through all these steps.

Feel free to disregard any of my review comments, or to tag me for more discussion. They're all just things I noticed while going through the project.

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-013.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-014.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-016.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-017.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-022.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-051.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-053.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-055.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-056.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-063.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-007.md

ShaunSHamilton

Some necessary suggestions. Some, because I think it would be more usable.

I have stopped reviewing at part-013, because GitHub is acting up. More suggestions are likely to come.

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-001.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-006.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-004.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-006.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-009.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-011.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-012.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-013.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-007.md

ShaunSHamilton

GitHub is making this more difficult than it normally is. So, apologies for the staggered reviews.

After going through this, I am leaning towards the suggestion of:

Instructions: Add a p element with at least 10 characters...
Then, the next lesson has all this boilerplate content

Overall, really satisfying to finish, but, at the same time, I was waiting, and waiting, and waiting for the .hero-title to be fixed on the preview so it did not cover the img:

That never happened, and it does look like a novice mistake - overlaying an image with text like that. I think we should consider fixing it by either:
a) Centering the .hero-title
b) Not setting it to position: absolute, and decreasing the font-size to something reasonable in the scale. e.g. maximum of 4rem. 3.6rem would actually be next in the scale

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-010.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-015.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-018.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-019.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-023.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-057.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-064.md

naomi-lgbt · 2021-10-14T22:49:12Z

Overall, really satisfying to finish, but, at the same time, I was waiting, and waiting, and waiting for the .hero-title to be fixed on the preview so it did not cover the img:

This could very well be a result of changing the content of this project, too. I'll give this a play and see what I come up with.

naomi-lgbt · 2021-10-14T22:51:15Z

Merge @ShaunSHamilton's PR, get conflicts on my own. 😠

Will apply review + resolve conflicts in the morning.

moT01

Found a few bugs and typos - and some firefix issues

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/step-007.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/step-008.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/step-009.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/step-020.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/step-028.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/step-029.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/step-030.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/step-047.md

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/step-063.md

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

ShaunSHamilton

This LGTM 👍

outdated

moT01

LGTM 🎉

naomi-lgbt · 2021-10-28T20:28:19Z

time for some rebases 😁

naomi-lgbt marked this pull request as ready for review September 22, 2021 21:50

naomi-lgbt requested a review from a team as a code owner September 22, 2021 21:50

ShaunSHamilton self-assigned this Sep 22, 2021

gikf reviewed Sep 23, 2021

View reviewed changes

naomi-lgbt requested a review from gikf September 24, 2021 18:02

Sembauke requested changes Sep 24, 2021

View reviewed changes

Sembauke previously requested changes Sep 24, 2021

View reviewed changes

gikf added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 28, 2021

raisedadead added status: merge conflict To be applied to PR's that have a merge conflict and need updating and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Oct 1, 2021

scissorsneedfoodtoo reviewed Oct 1, 2021

View reviewed changes

scissorsneedfoodtoo reviewed Oct 5, 2021

View reviewed changes

naomi-lgbt commented Oct 5, 2021

View reviewed changes

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-007.md Outdated Show resolved Hide resolved

naomi-lgbt force-pushed the feat/magazine branch from 2f5be6f to 211c222 Compare October 5, 2021 18:10

naomi-lgbt added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: merge conflict To be applied to PR's that have a merge conflict and need updating labels Oct 6, 2021

ShaunSHamilton requested changes Oct 9, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

naomi-lgbt requested a review from ShaunSHamilton October 14, 2021 18:27

ShaunSHamilton reviewed Oct 14, 2021

View reviewed changes

curriculum/challenges/english/01-responsive-web-design/css-grid-magazine/part-007.md Outdated Show resolved Hide resolved

ShaunSHamilton requested changes Oct 14, 2021

View reviewed changes

naomi-lgbt force-pushed the feat/magazine branch from cef2263 to f94151d Compare October 15, 2021 19:40

moT01 reviewed Oct 20, 2021

View reviewed changes

naomi-lgbt and others added 23 commits October 27, 2021 12:46

feat: write tests

972b98f

chore: apply gikf's review suggestions

9e678c2

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

chore: use correct alt text

e0b5927

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

fix: image size

c353332

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

feat: add temporary width

d45070c

chore: apply sem's review suggestions

c001881

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

chore: missed one

1d820b3

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

chore: apply kris' review suggestions

bd887cf

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

chore: no text walls

68cecb3

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

chore: walls of text

ea66616

chore: remaining review suggestions

419e6c2

chore: apply shaun's review suggestions

3f17e17

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

fix: linting index.md

a931c40

chore: lang tags

6d34575

feat: clarify noreferrer

6e20516

feat: clarify lazy loading

5818071

chore: apply shaun's review suggestions

7e95e8b

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

fix: note about justify

43f8050

fix: split step 7

6c7de42

fix: hero title

79029fc

chore: parts are secretly steps

088105a

chore: apply tom's review suggestions

479f649

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

chore: missed one

7f70781

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

naomi-lgbt force-pushed the feat/magazine branch from 903e029 to 7f70781 Compare October 27, 2021 19:47

ShaunSHamilton approved these changes Oct 28, 2021

View reviewed changes

moT01 approved these changes Oct 28, 2021

View reviewed changes

moT01 merged commit cb5244b into freeCodeCamp:main Oct 28, 2021

naomi-lgbt deleted the feat/magazine branch October 28, 2021 20:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: css magazine #43507

feat: css magazine #43507

naomi-lgbt commented Sep 20, 2021

gitpod-io bot commented Sep 20, 2021

gikf left a comment •

edited

scissorsneedfoodtoo left a comment

scissorsneedfoodtoo left a comment

ShaunSHamilton left a comment

This comment has been minimized.

ShaunSHamilton left a comment

naomi-lgbt commented Oct 14, 2021

naomi-lgbt commented Oct 14, 2021 •

edited

moT01 left a comment •

edited

ShaunSHamilton left a comment

moT01 left a comment

naomi-lgbt commented Oct 28, 2021

feat: css magazine #43507

feat: css magazine #43507

Conversation

naomi-lgbt commented Sep 20, 2021

gitpod-io bot commented Sep 20, 2021

gikf left a comment • edited

Choose a reason for hiding this comment

scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

ShaunSHamilton left a comment

Choose a reason for hiding this comment

This comment has been minimized.

ShaunSHamilton left a comment

Choose a reason for hiding this comment

naomi-lgbt commented Oct 14, 2021

naomi-lgbt commented Oct 14, 2021 • edited

moT01 left a comment • edited

Choose a reason for hiding this comment

ShaunSHamilton left a comment

Choose a reason for hiding this comment

moT01 left a comment

Choose a reason for hiding this comment

naomi-lgbt commented Oct 28, 2021

gikf left a comment •

edited

naomi-lgbt commented Oct 14, 2021 •

edited

moT01 left a comment •

edited