Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): Flex and Spacer components - UI Components #47231

Merged
merged 6 commits into from
Oct 10, 2022

Conversation

sirasitxp
Copy link
Contributor

@sirasitxp sirasitxp commented Aug 9, 2022

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

This is related to issue #44668

Clear part of Chapter components freeCodeCamp/chapter#1143

@sirasitxp sirasitxp requested a review from a team as a code owner August 9, 2022 19:30
@gitpod-io
Copy link

gitpod-io bot commented Aug 9, 2022

@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Aug 9, 2022
@ghost
Copy link

ghost commented Aug 9, 2022

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@Sboonny Sboonny requested review from ahmaxed and huyenltnguyen and removed request for Nirajn2311 and ShaunSHamilton August 9, 2022 20:21
Copy link
Member

@Sboonny Sboonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete client/core.3149 file from the commit? these aren't needed in the repo

@raisedadead raisedadead changed the title Request to add Flex and Spacer components to UI Components Library #44668 feat(tools): Flex and Spacer components - UI Components Aug 10, 2022
@raisedadead raisedadead added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Aug 10, 2022
@github-actions github-actions bot removed the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Aug 10, 2022
@sirasitxp
Copy link
Contributor Author

Can you delete client/core.3149 file from the commit? these aren't needed in the repo

Just did! Let me know if there is anything else to be done.

@raisedadead raisedadead added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. labels Oct 7, 2022
@raisedadead
Copy link
Member

✨ ✨ AWESOME! ✨ ✨

LGTM.

Thanks for this pull request and for contributing to the codebase for the first time. We will be looking forward to more contributions in the future.

Happy contributing.

@ahmaxed
Copy link
Member

ahmaxed commented Oct 10, 2022

Thanks for the pull request.

We are focusing on completing the #44668 requirements list for the first phase of the component library.

If you are still interested in contributing to component library, I suggest developing to the remaining components on the list first.

Note: the component library will be used in Chapter. As a result, building any component count as contributing to Chapter.

@ahmaxed ahmaxed merged commit 17ba240 into freeCodeCamp:main Oct 10, 2022
ahmaxed added a commit that referenced this pull request Oct 10, 2022
shootermv pushed a commit to shootermv/freeCodeCamp that referenced this pull request Dec 20, 2022
…#47231)

* implement: flex and spacer components

* implement: Flex and Spacer components

* delete core.3149

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants