Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): remove system colors variables from colors.css #49870

Merged
merged 1 commit into from
Apr 3, 2023
Merged

feat(tools): remove system colors variables from colors.css #49870

merged 1 commit into from
Apr 3, 2023

Conversation

Sboonny
Copy link
Member

@Sboonny Sboonny commented Mar 27, 2023

Checklist:

Although these can be fine, if we actively don't use them, we shouldn't be worried about these stuff while developing, and the library is going to be published soon, so this deletes the variables to not get in our future selves way

@Sboonny Sboonny added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 27, 2023
@Sboonny Sboonny requested a review from a team as a code owner March 27, 2023 08:37
@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Mar 27, 2023
@ghost
Copy link

ghost commented Mar 27, 2023

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@raisedadead raisedadead merged commit 3988d42 into freeCodeCamp:main Apr 3, 2023
@Sboonny Sboonny deleted the feat/remove-system-colors-from-colors-css branch May 8, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants