Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] implemented information about box-sizing #50724

Closed
wants to merge 11 commits into from
Closed

[fix] implemented information about box-sizing #50724

wants to merge 11 commits into from

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Jun 16, 2023

Checklist:

Closes #49156

Note: I created a better version of this pull request. Check #50786

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jun 16, 2023
@ghost
Copy link

ghost commented Jun 16, 2023

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Member

@Sembauke Sembauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CBID2,

Thank you for opening this pull-request, we like to introduce a new step before this step that introduces box-sizing.

If you need any help, let me know! We also have a good explanation on our contribution guidelines page.

@Sembauke Sembauke added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Jun 16, 2023
@CBID2
Copy link
Contributor Author

CBID2 commented Jun 16, 2023

Hey @CBID2,

Thank you for opening this pull-request, we like to introduce a new step before this step that introduces box-sizing.

If you need any help, let me know! We also have a good explanation on our contribution guidelines page.

Hi @Sembauke! Thank you for the suggestion, what step would that be?

@Sembauke
Copy link
Member

Hey @CBID2,

Adding a new step (challenge / file in your editor) before step 7.

You'll have to do some reading on how to add a new step here
https://contribute.freecodecamp.org/#/how-to-work-on-coding-challenges

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 16, 2023

Hey @CBID2,

Adding a new step (challenge / file in your editor) before step 7.

You'll have to do some reading on how to add a new step here

https://contribute.freecodecamp.org/#/how-to-work-on-coding-challenges

Thanks @Sembauke, but I'm still wondering what step I should add as far as what the camper should do before the box-sizing property.

@Sembauke
Copy link
Member

We need to add a lesson before this which introduces the box-sizing property to give clarification to the user.

I quoted this from the issue.

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 18, 2023

We need to add a lesson before this which introduces the box-sizing property to give clarification to the user.

I quoted this from the issue.

Oh ok

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 18, 2023

We need to add a lesson before this which introduces the box-sizing property to give clarification to the user.

I quoted this from the issue.

Hi @Sembauke! :) I added the lesson.

@CBID2 CBID2 requested a review from Sembauke June 18, 2023 00:42
@naomi-lgbt
Copy link
Member

I don't see a new lesson?

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 21, 2023

I don't see a new lesson?

Huh, I swore I had it in there @naomi-lgbt 🤔

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 21, 2023

I don't see a new lesson?

I did add it @naomi-lgbt. See line 10

@naomi-lgbt
Copy link
Member

That's extra text to the current lesson - I believe the planned implementation was to add an entirely new lesson (step) before this lesson.

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 21, 2023

That's extra text to the current lesson - I believe the planned implementation was to add an entirely new lesson (step) before this lesson.

Ohhh ok @naomi-lgbt. Any suggestions?

@naomi-lgbt
Copy link
Member

I would suggest a lesson that first has them set the box-sizing to content-box, explaining that this is the default and what it means.

Then update the current lesson to change content-box to border-box, and explain the difference.

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 21, 2023

I would suggest a lesson that first has them set the box-sizing to content-box, explaining that this is the default and what it means.

Then update the current lesson to change content-box to border-box, and explain the difference.

Ok thanks

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 21, 2023

#49156

I think I got it @naomi-lgbt! :)

@naomi-lgbt
Copy link
Member

I think there is still some misunderstanding here.

With your changes:

  • Step 7 teaches the content-box and border-box value.

The changes we want:

  • A new Step 7 should be created to teach the content-box
  • The old Step 7 (which becomes Step 8 with the new insertion) should teach border-box

@naomi-lgbt
Copy link
Member

You can refer to https://contribute.freecodecamp.org/#/how-to-work-on-practice-projects?id=insert-step-1 for how to insert a new step.

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 22, 2023

I think there is still some misunderstanding here.

With your changes:

  • Step 7 teaches the content-box and border-box value.

The changes we want:

  • A new Step 7 should be created to teach the content-box
  • The old Step 7 (which becomes Step 8 with the new insertion) should teach border-box

Ahh ok

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 22, 2023

You can refer to https://contribute.freecodecamp.org/#/how-to-work-on-practice-projects?id=insert-step-1 for how to insert a new step.

Hi @naomi-lgbt. I got this error when I followed the steps to open the challenge editor:
error

Update: I got it to work

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 22, 2023

Hey @naomi-lgbt. I made the changes. Hopefully, I got it right this time! 😄 🤞🏾

@CBID2 CBID2 requested a review from a team as a code owner June 22, 2023 03:19
@github-actions github-actions bot added the scope: i18n language translation/internationalization. Often combined with language type label label Jun 22, 2023
@raisedadead
Copy link
Member

Nice work so far.

Please ensure you follow the PR checklist and not just tick things off; otherwise, we won't take you seriously. Respect the requirements to earn the respect of your fellow maintainers. You will also save everyone time :)

Since you are new here, please pace yourself and read our contributing guidelines, as we see that you may still need to catch up on a few things.

Here are some examples (expand)
  1. Do not edit files directly on GitHub – while you can, it's not a good idea.

    Typos and formatting errors can break the tests.

  2. Use the correct way to link issues.

    Add the issue number only in the description of the PR by updating the XXXXXX. Do not just add issue numbers everywhere and anywhere you feel like.

  3. Keep mentions and review requests to a minimum.

    We understand you are excited about contributing, and our maintainers will get back to you when they can.

  4. Do not work directly off your main branch.

    You can always create a new branch for the changes you are working on. That way, you can sync change to your PR branch as the main repository moves ahead while your PR is waiting in the merge queue.

Looking forward to more contributions!

Happy Contributing.

@naomi-lgbt
Copy link
Member

Closing in favour of #50795

@naomi-lgbt naomi-lgbt closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
4 participants