-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] implemented information about box-sizing #50724
Conversation
👀 Review this PR in a CodeSee Review Map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CBID2,
Thank you for opening this pull-request, we like to introduce a new step before this step that introduces box-sizing.
If you need any help, let me know! We also have a good explanation on our contribution guidelines page.
Hi @Sembauke! Thank you for the suggestion, what step would that be? |
Hey @CBID2, Adding a new step (challenge / file in your editor) before step 7. You'll have to do some reading on how to add a new step here |
Thanks @Sembauke, but I'm still wondering what step I should add as far as what the camper should do before the box-sizing property. |
I quoted this from the issue. |
Oh ok |
Hi @Sembauke! :) I added the lesson. |
I don't see a new lesson? |
Huh, I swore I had it in there @naomi-lgbt 🤔 |
I did add it @naomi-lgbt. See line 10 |
That's extra text to the current lesson - I believe the planned implementation was to add an entirely new lesson (step) before this lesson. |
Ohhh ok @naomi-lgbt. Any suggestions? |
I would suggest a lesson that first has them set the box-sizing to content-box, explaining that this is the default and what it means. Then update the current lesson to change content-box to border-box, and explain the difference. |
Ok thanks |
I think I got it @naomi-lgbt! :) |
I think there is still some misunderstanding here. With your changes:
The changes we want:
|
You can refer to https://contribute.freecodecamp.org/#/how-to-work-on-practice-projects?id=insert-step-1 for how to insert a new step. |
Ahh ok |
Hi @naomi-lgbt. I got this error when I followed the steps to open the challenge editor: Update: I got it to work |
Hey @naomi-lgbt. I made the changes. Hopefully, I got it right this time! 😄 🤞🏾 |
Nice work so far. Please ensure you follow the PR checklist and not just tick things off; otherwise, we won't take you seriously. Respect the requirements to earn the respect of your fellow maintainers. You will also save everyone time :) Since you are new here, please pace yourself and read our contributing guidelines, as we see that you may still need to catch up on a few things. Here are some examples (expand)
Looking forward to more contributions! Happy Contributing. |
Closing in favour of #50795 |
Checklist:
main
branch of freeCodeCamp.Closes #49156
Note: I created a better version of this pull request. Check #50786