Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): implement a lesson about the box-sizing property #50795

Merged
merged 66 commits into from Sep 5, 2023
Merged

fix(curriculum): implement a lesson about the box-sizing property #50795

merged 66 commits into from Sep 5, 2023

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Jun 24, 2023 •
edited by naomi-lgbt

Checklist:

Closes #49156

I explained the box-sizing property in two separate steps. One focuses on the content-box value and its purpose while the other focuses on the border-box value and how it differs from the former. Through these changes, I anticipate that campers would gain a better understanding of the steps.

Edit by @naomi-lgbt: Because this adds new steps, I've synced the changes to the chinese and espanol directories to please the tests. Once merged, I'll manually run the upload and download flows to get every language updated properly.

@CBID2 CBID2 requested a review from a team as a code owner June 24, 2023 02:13
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Jun 24, 2023
@ghost
Copy link

ghost commented Jun 24, 2023 •
edited by ghost

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 24, 2023

Note: Apparently Step 6 is failing, but I never touched that step.

This was referenced Jun 26, 2023
Closed
Closed
@shootermv
Copy link
Contributor

i tried to figure out what is the reason for failing tests -
my guess (only guess) is - step 7 has a tests (hints) but - there is nothing that user required to do (editable)

@CBID2 CBID2 marked this pull request as draft July 5, 2023 02:52
shootermv
shootermv reviewed Jul 30, 2023
View reviewed changes
...sive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/6493bc0d99879635209565aa.md Show resolved Hide resolved
...sive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/6493bc0d99879635209565aa.md Show resolved Hide resolved
...sive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/615380dff67172357fcf0425.md Outdated Show resolved Hide resolved
...sive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/615389bd81347947ea7ba896.md Outdated Show resolved Hide resolved
...sive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/6153893900438b4643590367.md Show resolved Hide resolved
...sive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/6494da0daf5df5197963671d.md Show resolved Hide resolved
@raisedadead raisedadead reopened this Jul 31, 2023
@moT01
Copy link
Member

moT01 commented Jul 31, 2023 •
edited

I believe the tests aren't running here because of the conflicts @CBID2. I would try fixing those and see if that works. The meta.json files were changed recently to use objects instead of arrays. The tests stopped running on this PR after that PR got merged. You will need to change the meta file to align with that. Let us know if you need any guidance or anything with it.

@CBID2
Copy link
Contributor Author

CBID2 commented Jul 31, 2023

I believe the tests aren't running here because of the conflicts @CBID2. I would try fixing those and see if that works. The meta.json files were changed recently to use objects instead of arrays. The tests stopped running on this PR after that PR got merged. You will need to change the meta file to align with that. Let us know if you need any guidance or anything with it.

Thanks @moT01! :) I'll let you know

@CBID2 CBID2 requested a review from naomi-lgbt August 17, 2023 17:13
jdwilkin4
jdwilkin4 requested changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the whole project.
It looks good. 👍
Left a few comments

...sive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/615f171d05def3218035dc85.md Outdated Show resolved Hide resolved
...sive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/615f171d05def3218035dc85.md Outdated Show resolved Hide resolved
...sive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/615f171d05def3218035dc85.md Outdated Show resolved Hide resolved
...sive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/615389bd81347947ea7ba896.md Outdated Show resolved Hide resolved
@CBID2 @jdwilkin4
fix: revise word formatting
991804b 
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
@camperbot

This comment was marked as resolved.

Sign in to view
@CBID2 @jdwilkin4
fix: word formatting
362a8aa 
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
@camperbot

This comment was marked as resolved.

Sign in to view
@CBID2 @jdwilkin4
fix: revise formatting of more words
587279b 
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
@camperbot

This comment was marked as resolved.

Sign in to view
@camperbot

This comment was marked as resolved.

Sign in to view
@camperbot

This comment was marked as duplicate.

Sign in to view
@camperbot

This comment was marked as resolved.

Sign in to view
@camperbot

This comment was marked as resolved.

Sign in to view
@camperbot

This comment was marked as resolved.

Sign in to view
@camperbot

This comment was marked as resolved.

Sign in to view
jdwilkin4
jdwilkin4 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gone through the steps again and the new changes work now 👍

@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 28, 2023
@CBID2
Copy link
Contributor Author

CBID2 commented Aug 28, 2023

I have gone through the steps again and the new changes work now 👍

Yay! Thanks @jdwilkin4

@naomi-lgbt naomi-lgbt merged commit 578d162 into freeCodeCamp:main Sep 5, 2023
23 of 24 checks passed
@naomi-lgbt
Copy link
Member

Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 🎉

@CBID2 CBID2 deleted the implementing-lesson-about-box-sizing branch September 5, 2023 14:47
@CBID2
Copy link
Contributor Author

CBID2 commented Sep 5, 2023

Thank you for your contribution to the page! 👍

We are happy to accept these changes and look forward to future contributions. 🎉

This is awesome! :)

@naomi-lgbt naomi-lgbt mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shootermv shootermv shootermv left review comments

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
7 participants
@CBID2 @shootermv @moT01 @naomi-lgbt @camperbot @jdwilkin4 @raisedadead