Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: detuplication #50955

Merged
merged 6 commits into from
Jul 13, 2023
Merged

chore: detuplication #50955

merged 6 commits into from
Jul 13, 2023

Conversation

naomi-lgbt
Copy link
Member

@naomi-lgbt naomi-lgbt commented Jul 12, 2023 •
edited

Checklist:

As mentioned in #50769 (review), this migrates the meta.json files to use objects instead of tuples.

["alskjfadslkfj", "Step 1"] ➡️ {id: "alskjfadslkfj", title: "Step 1"}

I think I've managed not to break anything.

@naomi-lgbt naomi-lgbt requested a review from a team as a code owner July 12, 2023 16:43
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Jul 12, 2023
@ghost
Copy link

ghost commented Jul 12, 2023 •
edited by ghost

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@naomi-lgbt naomi-lgbt changed the title chore: no more tuples chore: detuplication Jul 12, 2023
chore(tests): update schema
9079c64 
how did this pass locally
ojeytonwilliams
ojeytonwilliams approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks, so I'm happy to approve as is.

Thanks, Naomi!

tools/challenge-helper-scripts/repair-meta.ts Outdated Show resolved Hide resolved
tools/challenge-helper-scripts/helpers/get-challenge-order.ts Outdated Show resolved Hide resolved
tools/challenge-helper-scripts/helpers/get-challenge-order.ts Outdated Show resolved Hide resolved
Naomi Carrigan and others added 2 commits July 12, 2023 11:03
@ojeytonwilliams
chore: apply oliver's review suggestion
6654a2c 
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
chore(tests): use real ids
ccc23a5 
Because matter parses `id: 1` as a number not a string ):<
@Sembauke Sembauke merged commit ab640ab into freeCodeCamp:main Jul 13, 2023
18 checks passed
@naomi-lgbt naomi-lgbt deleted the chore/no-more-tuples branch July 13, 2023 15:32
This was referenced Jul 31, 2023
Open
Merged
@lloydchang
Copy link

As mentioned in #50769 (review), this migrates the meta.json files to use objects instead of tuples.

I believe this relates to freeCodeCamp/classroom#410 (comment)

Context: feat: Detect changes coming from FCC API responses inside of the classroom mode project #410

@moT01 moT01 mentioned this pull request Jul 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

@Sembauke Sembauke Sembauke approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@naomi-lgbt @lloydchang @ojeytonwilliams @Sembauke