Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): automatically lowercase directories #53729

Merged

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Feb 14, 2024

Checklist:

Closes #XXXXX

I wanted to use the lowercase directories plugin but because I forgot that the total number of directories underneath the relevant folders isn't known and can change over time, it was best to use a shell command.

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Feb 14, 2024
@ghost
Copy link

ghost commented Feb 14, 2024

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I think it might be better to update the plugin to be recursive?

@moT01 moT01 added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label May 16, 2024
@ojeytonwilliams
Copy link
Contributor

Hi @a2937 are you still working on this? If you are, could you have a look at the merge conflict?

@a2937
Copy link
Member Author

a2937 commented May 23, 2024

I will work on getting this finished as soon as I an able to though.

@ojeytonwilliams
Copy link
Contributor

Awesome, thanks @a2937. We just weren't sure if you were still working on this. There's no rush, though, please take whatever time you need.

@a2937 a2937 force-pushed the feat(tools/scripts)/use-lowercase-dir-plugin branch from 655343a to 0aa3a45 Compare May 24, 2024 17:10
@a2937 a2937 marked this pull request as ready for review May 26, 2024 16:01
@a2937 a2937 requested a review from a team as a code owner May 26, 2024 16:01
@a2937 a2937 requested a review from naomi-lgbt May 26, 2024 16:01
@naomi-lgbt naomi-lgbt added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: merge conflict To be applied to PR's that have a merge conflict and need updating labels May 26, 2024
@Sembauke Sembauke merged commit d3cfdb9 into freeCodeCamp:main Jun 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants