-
-
Notifications
You must be signed in to change notification settings - Fork 37.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reorganise playwright config #53884
chore: reorganise playwright config #53884
Conversation
Playwright seems to expect the node_modules to be in the root
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/@fortawesome/fontawesome-common-types@6.4.2 |
Do you think this is the cause of webkit test failures we had back in Hacktoberfest? It has been bugging me for quite a while now, so it's really great if this change resolves the issue. |
It probably caused some confusion since users likely didn't realise why (or if) they were authenticated. Do you remember much about those failures? I can't remember much, to be honest, so I'm not sure if this would have mattered. |
Checklist:
main
branch of freeCodeCamp.Playwright seems to expect to be run from the root and, if not, it does not automatically run project dependencies. i.e. global-setup.ts should run before any other tests, but does not if the dependencies are inside e2e/node_modules.