-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): map progress ui #54576
fix(client): map progress ui #54576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping on this @ahmaxed. I gave it a quick look - here's what I see:
Looks good in Chrome. I played with it a bit - couldn't quite get it right, but have some ideas. Let me know if you want to pair up on it for a bit. Since deployments are sort of blocked until we get this looking a little better, maybe it's okay to just have it look good in Chrome temporarily if we need to.
I also kind of feel like only the core curriculum needs the numbers. Not sure if we should just omit the icons for the rest - I think I would be fine with that - or we could maybe use some neutral icons, like just a circle without the number, and the ribbons if isCert
We can definitely pair on it. I agree, the items outside of the curriculum set should not have numbers or arrows. |
The arrows seem no longer centred. |
Tom's changes are LGMT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist:
Update index.md
)main
branch of freeCodeCamp.