Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): make the progression arrows be centered #54595

Conversation

mmatsumoto1026
Copy link
Contributor

@mmatsumoto1026 mmatsumoto1026 commented May 1, 2024

Checklist:

Closes #XXXXX

Edit: related PR is #54576.

This PR was opened to make the progression arrows be vertically horizontally centered on any viewport width including small mobile devices.

before after
arrows_not_centered_in_mobile_device_1 arrows_centered_in_mobile_device_1

By using gitpod, the code was tested with following environment.

  1. Windows 11 Home PC using Chrome, Firefox, Edge, and Brave browser, or, webkit within the Playwright.
  2. Android Studio's emulator(Pixel 6 Pro with Android API 34 system image) using Chrome.
  3. iPhone SE (iOS 15.7.8) using Chrome and Firefox browser.

@mmatsumoto1026 mmatsumoto1026 requested a review from a team as a code owner May 1, 2024 16:19
@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label May 1, 2024
@mmatsumoto1026
Copy link
Contributor Author

I'm not sure it is what the designer intended, but I tried to make the progression arrows be vertically aligend so they will be fully responsible as shown in below.

make the progression arrows fully responsive
make_progression_arrows_vertically_centered.mp4

@Sembauke
Copy link
Member

Sembauke commented May 2, 2024

It seems that the arrow heads are invisible too. That is an issue.

@ahmaxed
Copy link
Member

ahmaxed commented May 2, 2024

The arrow heads were removed intentionally.

Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ahmaxed
Copy link
Member

ahmaxed commented May 6, 2024

Thanks for centering it.
It seems like we need another method to show the line.
perhaps a div with a border that goes behind the ribbons.

@ahmaxed ahmaxed merged commit c5f67ce into freeCodeCamp:main May 6, 2024
22 checks passed
@mmatsumoto1026 mmatsumoto1026 deleted the fix/make-the-progression-arrows-be-centered branch May 6, 2024 10:45
@mmatsumoto1026
Copy link
Contributor Author

perhaps a div with a border that goes behind the ribbons.

Actually, I agree with you because with the method, we will be able to avoid using svg image for showing the line, and also, we may be able to expand or shrink the length of the lines as need.

@ahmaxed
Copy link
Member

ahmaxed commented May 6, 2024

Github has a good example.

Screenshot 2024-05-06 at 3 52 39 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants