-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UI): make the progression arrows be centered #54595
fix(UI): make the progression arrows be centered #54595
Conversation
I'm not sure it is what the designer intended, but I tried to make the progression arrows be vertically aligend so they will be fully responsible as shown in below. make the progression arrows fully responsivemake_progression_arrows_vertically_centered.mp4 |
It seems that the arrow heads are invisible too. That is an issue. |
The arrow heads were removed intentionally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thanks for centering it. |
Actually, I agree with you because with the method, we will be able to avoid using svg image for showing the line, and also, we may be able to expand or shrink the length of the lines as need. |
Checklist:
main
branch of freeCodeCamp.Closes #XXXXX
Edit: related PR is #54576.
This PR was opened to make the progression arrows be
verticallyhorizontally centered on any viewport width including small mobile devices.By using gitpod, the code was tested with following environment.