Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client): migrate lower jaw buttons to Button component #54906

Merged
merged 6 commits into from
May 31, 2024
Merged

refactor(client): migrate lower jaw buttons to Button component #54906

merged 6 commits into from
May 31, 2024

Conversation

juancaorg
Copy link
Contributor

@juancaorg juancaorg commented May 21, 2024 •
edited by huyenltnguyen
Loading

Checklist:

Ref #54892

As suggested by @huyenltnguyen, the hover effect issue got fixed by migrating it to the new fCC Button component.

It may be worth to migrate all the buttons in lower-jaw.tsx in this PR. If so, please let me know.

Video demo

CleanShot.2024-05-21.at.08.19.33.mp4

@juancaorg juancaorg requested a review from a team as a code owner May 21, 2024 14:21
@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label May 21, 2024
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 22, 2024
@huyenltnguyen huyenltnguyen self-assigned this May 23, 2024
huyenltnguyen
huyenltnguyen reviewed May 23, 2024
View reviewed changes
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

It may be worth to migrate all the buttons in lower-jaw.tsx in this PR. If so, please let me know.

Yes, I think we should migrate all buttons in the lower jaw to the Button component 🙂

client/src/templates/Challenges/classic/lower-jaw.tsx Outdated Show resolved Hide resolved
@huyenltnguyen huyenltnguyen added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 23, 2024
@huyenltnguyen huyenltnguyen changed the title fix(curriculum): Submit and go to next challenge button Hover effect not working refactor(client): migrate lower jaw buttons to Button component May 23, 2024
@juancaorg
Copy link
Contributor Author

@huyenltnguyen addressed comments. However, because of these changes, I found an issue that I can't get around. Asking for feedback.

@huyenltnguyen huyenltnguyen added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels May 30, 2024
@ahmaxed ahmaxed merged commit 72c862e into freeCodeCamp:main May 31, 2024
20 checks passed
@juancaorg juancaorg deleted the fix/submit-and-go-button branch May 31, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmaxed ahmaxed ahmaxed approved these changes

@huyenltnguyen huyenltnguyen huyenltnguyen approved these changes

Assignees

@ahmaxed ahmaxed

Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juancaorg @ahmaxed @huyenltnguyen @jdwilkin4