Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 663d5bebe2eef6128a0b1e75.md #54932

Closed
wants to merge 2 commits into from
Closed

Conversation

ARMummert
Copy link

@ARMummert ARMummert commented May 23, 2024

Checklist:

Closes #54930 & #54926

I changed the description for step 6 of the Review DOM project. I used the updated example given in the issue.
I also changed the sentence in learn-introductory-javascripts-by-building-a-pyramid-generator from declare a character variable in your code to -> Use the let keyword to declare a variable called character.

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 23, 2024
@JoyShaheb JoyShaheb added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. new javascript course These are for issues dealing with the new JS curriculum labels May 23, 2024
Copy link
Contributor

@JoyShaheb JoyShaheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work 👍

@gikf
Copy link
Member

gikf commented May 23, 2024

Hello,

Firstly, thank you for submitting this pull request!

As you navigate through the process, we have a PR checklist to ensure consistency and quality in our contributions. We kindly ask that you genuinely follow through with each point. This not only facilitates the review process but also demonstrates a mutual respect for the community's efforts.

If you're unfamiliar with certain aspects, our contributing guidelines are a helpful resource to get you up to speed.

**Friendly Pointers (click to expand)**
  1. Editing on GitHub: While it's possible to edit files directly on GitHub, it's typically better not to. This helps avoid inadvertent mistakes like typos that can disrupt tests.

  2. Pull Request Title: Please ensure the PR title follows our convention.

  3. Linking Issues: Please ensure you link issues using the designated method. Simply update the XXXXXX in the PR description to include the issue number. This keeps our records organized and clear.

  4. Engaging with the Team: We know you're eager, but kindly keep mentions and review requests limited. Our maintainers are always on the lookout and will attend to PRs in the order they come in.

  5. Branch Management: It's a good practice not to work directly off your main branch. Creating separate branches for different changes allows you to smoothly update your PR even as the main repository progresses.

Please note, there's no need to close this PR. If you have questions or need guidance refining your contribution, don't hesitate to ask. Our community is here to assist.

Thank you for your enthusiasm in contributing to our project. We eagerly await more contributions from you!

Happy Contributing! 🌟

@huyenltnguyen huyenltnguyen added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 23, 2024
@camperbot
Copy link
Contributor

This PR seems to make similar changes as an existing PR. As such, we are going to close this as a duplicate.

If you feel you have additional changes to expand upon this PR, please feel free to push your commits and request this PR be reopened.

Thanks again! 😊


If you have any questions, feel free to ask questions on the "Contributors" category on our forum or the contributors chat room.

@camperbot camperbot closed this May 23, 2024
@ilenia-magoni ilenia-magoni removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update description for step 6 of Review DOM project
6 participants