Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

Remove port 8080 in URLs in Google API config guide and add missing project creation step #203

Closed
karuppiah7890 opened this issue Sep 18, 2017 · 12 comments

Comments

@karuppiah7890
Copy link
Contributor

karuppiah7890 commented Sep 18, 2017

https://github.com/freeCodeCamp/mail-for-good/wiki/How-to-configure-your-Google-API-Keys
We need to add Project creation step for creating a Mail for Good project

I think we need to look into the docs completely and try the setup once to see if the docs are up to date with the new code and config

@karuppiah7890
Copy link
Contributor Author

Similar to #194

@wadleo
Copy link
Contributor

wadleo commented Sep 18, 2017

The current docs aren't update to with the update Google Api Keys site, I will sent a pull request to fix this soon.

@karuppiah7890
Copy link
Contributor Author

@wadleo Not really. I think it's up to date. Can you be more specific on what's missing ?

@wadleo
Copy link
Contributor

wadleo commented Sep 18, 2017

yeah @karuppiah7890 , you are correct the guide here matches the Google API management site, but I think developers who are new to using the Google API site would find it difficult because you have to start by selecting a project or creating a new project, before following the steps in the guide. I think that is the only step missing. When the user logins into Google API site, selects the project(mail-for-good) on the top left drop-down or add another project on the dialog box that opens. before following all the steps here. I think this will make the guide more explicit and least confusing. If this is ok with you, I will send a PR to update this guide and the ports mentioned above.

@karuppiah7890
Copy link
Contributor Author

Oh yes. I did think about the project creation

@karuppiah7890
Copy link
Contributor Author

@wadleo Sure! PRs are welcome 😄

@karuppiah7890 karuppiah7890 changed the title Remove port 8080 in URLs in Google API config guide Remove port 8080 in URLs in Google API config guide and add missing project creation step Sep 18, 2017
@wadleo
Copy link
Contributor

wadleo commented Sep 18, 2017

Hi @karuppiah7890 here is my change, https://github.com/wadleo/mail-for-good-wiki but I need help to create a PR to this issue, since it is not possible to send pull request for wikis on github, since there aren't part of the cloned or forked project.

@karuppiah7890
Copy link
Contributor Author

karuppiah7890 commented Sep 19, 2017

Oh yes, I know. Hey @zhakkarn can you help here in making a change in this Wiki ?

Also, @wadleo remove the port number 80 in the file, as it's not needed. Just http://localhost is fine, as browsers will try to access port 80 by default when the protocol is http as 80 is the default listening port for HTTP servers

@wadleo
Copy link
Contributor

wadleo commented Sep 19, 2017

ok I will update the guide

@AndrewWalsh
Copy link
Contributor

@wadleo Thank you for raising this to our attention.

@karuppiah7890 @wadleo Has this been addressed? If so we can close this.

@karuppiah7890
Copy link
Contributor Author

@AndrewGHC No, it hasn't been addressed

zhakk-harn added a commit that referenced this issue Oct 1, 2017
Added missing step when setting up google api keys for deployment #203
zhakk-harn pushed a commit that referenced this issue Oct 1, 2017
* resolved issue #203

-'docker-compose up' to 'sudo docker-compose up'

-Port numbers corrected.
@wadleo
Copy link
Contributor

wadleo commented Oct 3, 2017

I think this problem has been completely solved now from the commits above. I think we can close this issue now

zhakk-harn pushed a commit that referenced this issue Dec 5, 2017
* Correcting port numbers and adding "sudo" to "docker-compose up"

* resolved issue #203

-'docker-compose up' to 'sudo docker-compose up'

-Port numbers corrected.

* Disambiguate port usage in GOOGLE_CALLBACK in .env.example (#245)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants