Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing currency #23

Open
joeyhub opened this issue Sep 26, 2019 · 4 comments
Open

Missing currency #23

joeyhub opened this issue Sep 26, 2019 · 4 comments

Comments

@joeyhub
Copy link

joeyhub commented Sep 26, 2019

MRO seems to be missing.

I'm not sure if that's an effort to keep the library current or not but people will have records going back while MRO was still in use so need that to maintain integrity.

For whatever reason it's missing, it would be useful to have an additional column to indicate if the currency is still in use / circulation or not.

@joeyhub
Copy link
Author

joeyhub commented Sep 26, 2019

https://en.wikipedia.org/wiki/Mauritanian_ouguiya

See here that they "replaced" MRO with MRU.

Do you strip retired?

@freeall
Copy link
Owner

freeall commented Sep 27, 2019

I can't exactly remember now, but it seems that I've taken the active list from the wikipedia article.

We could add an active flag to the dataset and include the historical currencies.

If you add that in a PR I can take a look at it.

@joeyhub
Copy link
Author

joeyhub commented Sep 27, 2019

Active would make sense.

Mapping isn't necessarily so important, more of a thought. When a country changes one currency to another in the standard cases the previous is kaput rather than interchangeable with the previous.

Although mapping would be informative about the history of a country's currency transitions, I think think there are actually many use cases where it would be actionable.

I think the wiki will be from ISO. ISO can be a bit of a pain because it's behind a paywall and last time I considered paying for something (not too hard though) I wasn't immediately presented with a list containing any options that were obviously machine readable exports.

Using ISO as the limit for historical cut off would make sense. Otherwise adding Roman currency, etc would be too much (no one but a handful of historians or coin collectors will have computer records going that far and I'd assume if need be they'd establish their own standardised database for that).

I say ISO only for that because it's not entirely out of the question for more than one source for active currencies to eventually come up, IE, does the ISO collection consider virtual, etc? Though that's not at all an immediate concern as much as future proof.

moneyphp/iso-currencies#8

This does come up sometimes in other places.

A search shows me some lists without MRO.

I wonder if this is a source problem, IE, by default ISO releases live currencies and people are using only that without bothering to get a historic list or not one available making the only way to take all release and merge them.

When I have some time I'll dig into what's actually on the ISO website.

@joeyhub
Copy link
Author

joeyhub commented Sep 27, 2019

A quick survey seems to suggest ISO is being a pain with the way they chain their currency standards (ISO 4217:YEAR) requiring an archaeologist to piece things together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants