-
Notifications
You must be signed in to change notification settings - Fork 742
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
lang/go118: Revert upstream CL 411617
Revert https://go-review.googlesource.com/c/go/+/411617 that introduced the regression that broke security/gopass and security/git-credential-gopass. See golang/go#53852 for more details.
- Loading branch information
Showing
2 changed files
with
19 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
lang/go118/files/patch-src_cmd_compile_internal_noder_stencil.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
Revert "[release-branch.go1.18] cmd/compile: fix missing dict pass for type assertions" | ||
https://go-review.googlesource.com/c/go/+/417615 | ||
|
||
--- src/cmd/compile/internal/noder/stencil.go.orig 2022-07-12 15:22:53 UTC | ||
+++ src/cmd/compile/internal/noder/stencil.go | ||
@@ -1297,10 +1297,10 @@ func (g *genInst) dictPass(info *instInfo) { | ||
m = convertUsingDictionary(info, info.dictParam, m.Pos(), mce.X, m, m.Type(), false) | ||
} | ||
case ir.ODOTTYPE, ir.ODOTTYPE2: | ||
- dt := m.(*ir.TypeAssertExpr) | ||
- if !dt.Type().HasShape() && !dt.X.Type().HasShape() { | ||
+ if !m.Type().HasShape() { | ||
break | ||
} | ||
+ dt := m.(*ir.TypeAssertExpr) | ||
var rt ir.Node | ||
if dt.Type().IsInterface() || dt.X.Type().IsEmptyInterface() { | ||
ix := findDictType(info, m.Type()) |