-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x11/gbsddialog: add new port #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than a few minor nits.
share/applications/bsdconfig.desktop | ||
share/doc/gbsddialog/README.md | ||
share/icons/hicolor/48x48/apps/bsdconfig.png | ||
%%PORTDOCS%%%%DOCSDIR%%/samples/Xdialog.wrapper.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thnk you're missing %%PORTDOCS%%%%DOCSDIR%%/COPYING
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thnk you're missing
%%PORTDOCS%%%%DOCSDIR%%/COPYING
.
Isn't it already automatically copied as /usr/local/share/licenses/gbsddialog-0.8.1/BSD2CLAUSE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still have to account for it, otherwise, Q/A tests will fail.
===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/COPYING
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, I have been running make stage-qa
both with and without the DOCS
option, and this warning never triggered.
Should I also change the line for README.md
to be in %%PORTDOCS%%%%DOCSDIR%%
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the entries for both README.md
and COPYING
could be
%%PORTDOCS%%%%DOCSDIR%%/COPYING
%%PORTDOCS%%%%DOCSDIR%%/README.md
That is what most other ports are doing.
% rg --no-heading -Ig "*/*/pkg-plist" "%%DOCSDIR%%/COPYING" | wc -l
232
% rg --no-heading -Ig "*/*/pkg-plist" "%%PORTDOCS%%%%DOCSDIR%%/COPYING" | wc -l
202
% rg --no-heading -Ig "*/*/pkg-plist" "%%DOCSDIR%%/README" | wc -l
1727
% rg --no-heading -Ig "*/*/pkg-plist" "%%PORTDOCS%%%%DOCSDIR%%/README" | wc -l
1576
5b9d64c
to
a022816
Compare
gbsddialog is an implementation of bsddialog, a text-based user interface to be used in scripts and tools, such as in the official FreeBSD installer, bsdinstall(8). gbsddialog uses Gtk+ dialogs and widgets instead of console-based equivalents. The objective is to reproduce the same behaviour as the original tool, respecting the exact command-line parameters and output. gbsddialog can then be used as a drop-in replacement to bsddialog, effectively granting the possibility to install and configure FreeBSD entirely in graphical mode. In addition, an implementation of Xdialog is also provided, for use with bsdconfig(8) when invoked in graphical mode with -S or -X. Sponsored by: The FreeBSD Foundation
a022816
to
eaff499
Compare
gbsddialog is an implementation of bsddialog, a text-based user interface to be used in scripts and tools, such as in the official FreeBSD installer, bsdinstall(8). gbsddialog uses Gtk+ dialogs and widgets instead of console-based equivalents. The objective is to reproduce the same behaviour as the original tool, respecting the exact command-line parameters and output. gbsddialog can then be used as a drop-in replacement to bsddialog, effectively granting the possibility to install and configure FreeBSD entirely in graphical mode. In addition, an implementation of Xdialog is also provided, for use with bsdconfig(8) when invoked in graphical mode with -S or -X. Reviewed by: jrm Sponsored by: The FreeBSD Foundation Pull Request: #235
You could've just do |
gbsddialog is an implementation of bsddialog, a text-based user interface to be used in scripts and tools, such as in the official FreeBSD installer, bsdinstall(8). gbsddialog uses Gtk+ dialogs and widgets instead of console-based equivalents. The objective is to reproduce the same behaviour as the original tool, respecting the exact command-line parameters and output. gbsddialog can then be used as a drop-in replacement to bsddialog, effectively granting the possibility to install and configure FreeBSD entirely in graphical mode.
In addition, an implementation of Xdialog is also provided, for use with bsdconfig(8) when invoked in graphical mode with -S or -X.
Sponsored by: The FreeBSD Foundation