x11/gbsddialog: add new port #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jehops
suggested changes
Feb 18, 2024
| share/applications/bsdconfig.desktop | ||
| share/doc/gbsddialog/README.md | ||
| share/icons/hicolor/48x48/apps/bsdconfig.png | ||
| %%PORTDOCS%%%%DOCSDIR%%/samples/Xdialog.wrapper.c |
There was a problem hiding this comment.
I thnk you're missing %%PORTDOCS%%%%DOCSDIR%%/COPYING.
There was a problem hiding this comment.
I thnk you're missing
%%PORTDOCS%%%%DOCSDIR%%/COPYING.
Isn't it already automatically copied as /usr/local/share/licenses/gbsddialog-0.8.1/BSD2CLAUSE?
There was a problem hiding this comment.
You still have to account for it, otherwise, Q/A tests will fail.
===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/COPYING
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
There was a problem hiding this comment.
Strange, I have been running make stage-qa both with and without the DOCS option, and this warning never triggered.
Should I also change the line for README.md to be in %%PORTDOCS%%%%DOCSDIR%%?
There was a problem hiding this comment.
I think the entries for both README.md and COPYING could be
%%PORTDOCS%%%%DOCSDIR%%/COPYING
%%PORTDOCS%%%%DOCSDIR%%/README.md
That is what most other ports are doing.
% rg --no-heading -Ig "*/*/pkg-plist" "%%DOCSDIR%%/COPYING" | wc -l
232
% rg --no-heading -Ig "*/*/pkg-plist" "%%PORTDOCS%%%%DOCSDIR%%/COPYING" | wc -l
202
% rg --no-heading -Ig "*/*/pkg-plist" "%%DOCSDIR%%/README" | wc -l
1727
% rg --no-heading -Ig "*/*/pkg-plist" "%%PORTDOCS%%%%DOCSDIR%%/README" | wc -l
1576
khorben
force-pushed
the
khorben/gbsddialog-0.8.1
branch
from
5b9d64c
to
a022816
Compare
gbsddialog is an implementation of bsddialog, a text-based user interface to be used in scripts and tools, such as in the official FreeBSD installer, bsdinstall(8). gbsddialog uses Gtk+ dialogs and widgets instead of console-based equivalents. The objective is to reproduce the same behaviour as the original tool, respecting the exact command-line parameters and output. gbsddialog can then be used as a drop-in replacement to bsddialog, effectively granting the possibility to install and configure FreeBSD entirely in graphical mode. In addition, an implementation of Xdialog is also provided, for use with bsdconfig(8) when invoked in graphical mode with -S or -X. Sponsored by: The FreeBSD Foundation
khorben
force-pushed
the
khorben/gbsddialog-0.8.1
branch
from
a022816
to
eaff499
Compare
freebsd-git
pushed a commit
that referenced
this pull request
Feb 21, 2024
gbsddialog is an implementation of bsddialog, a text-based user interface to be used in scripts and tools, such as in the official FreeBSD installer, bsdinstall(8). gbsddialog uses Gtk+ dialogs and widgets instead of console-based equivalents. The objective is to reproduce the same behaviour as the original tool, respecting the exact command-line parameters and output. gbsddialog can then be used as a drop-in replacement to bsddialog, effectively granting the possibility to install and configure FreeBSD entirely in graphical mode. In addition, an implementation of Xdialog is also provided, for use with bsdconfig(8) when invoked in graphical mode with -S or -X. Reviewed by: jrm Sponsored by: The FreeBSD Foundation Pull Request: #235
|
You could've just do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gbsddialog is an implementation of bsddialog, a text-based user interface to be used in scripts and tools, such as in the official FreeBSD installer, bsdinstall(8). gbsddialog uses Gtk+ dialogs and widgets instead of console-based equivalents. The objective is to reproduce the same behaviour as the original tool, respecting the exact command-line parameters and output. gbsddialog can then be used as a drop-in replacement to bsddialog, effectively granting the possibility to install and configure FreeBSD entirely in graphical mode.
In addition, an implementation of Xdialog is also provided, for use with bsdconfig(8) when invoked in graphical mode with -S or -X.
Sponsored by: The FreeBSD Foundation