Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Issue template uses ** rather than # #150

Closed
joker314 opened this issue Jul 15, 2018 · 3 comments · Fixed by #152
Closed

Issue template uses ** rather than # #150

joker314 opened this issue Jul 15, 2018 · 3 comments · Fixed by #152

Comments

@joker314
Copy link
Contributor

joker314 commented Jul 15, 2018 •
edited
Loading

Describe the bug
The issue template bolds headings (**heading**)

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/freeCodeCamp/curriculum/issues/new?template=bug_report.md
  2. Observe headings

Expected behavior
It would be more semantically correct to use #s. This could also make navigation either on some users' set-ups (e.g. if they have certain things set up to mark out headings)
@joker314
Copy link
Contributor Author

I would love to fix this myself if people agree we should change this?

@joker314
Copy link
Contributor Author

The PR template currently uses ####. I think the issue template should do the same: it doesn't make a visual difference but does make a semantic one so I'm going to go ahead and make the PR(?)

joker314 added a commit to joker314/curriculum that referenced this issue Jul 15, 2018
@joker314
fix: make issue template headers semantic
fa9ca87 
Replace \`**\`, which causes the \`<strong>\` tag to be used, into \`####\`, which causes the \`<h4>\` tag
to be used. This is more semantic because these are headers, and \`<h4>\` is used for headers. This
makes no visual changes when viewed on GitHub.

ISSUES CLOSED: freeCodeCamp#150
@joker314 joker314 mentioned this issue Jul 15, 2018
Merged
7 tasks
erictleung pushed a commit that referenced this issue Jul 24, 2018
@joker314 @erictleung
Make issue template headers semantic (#152)
380f4cf 
Closes #150
@raisedadead
Copy link
Member

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make issue template headers semantic joker314/curriculum
2 participants
@raisedadead @joker314