Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Build a JavaScript Calculator tests typo #1457

Closed
getuliosilva opened this issue Jun 8, 2022 · 3 comments · Fixed by #1458
Closed

Build a JavaScript Calculator tests typo #1457

getuliosilva opened this issue Jun 8, 2022 · 3 comments · Fixed by #1458

Comments

@getuliosilva
Copy link
Contributor

On the tests for the Build a JavaScript Calculator challenge, line 339:

'The sequence "5 + 3 = + 3 =" should produce an output of "13" '

should read:
'The sequence "5 + 5 = + 3 =" should produce an output of "13" '
right?

@ShaunSHamilton
Copy link
Member

Thank you, for taking the time to open this.

Yes, you are correct.


I have opened this up to first-timers to contribute to.

@getuliosilva
Copy link
Contributor Author

I'm working on a pull request for this issue.

@getuliosilva
Copy link
Contributor Author

getuliosilva commented Jun 14, 2022

I need help, is commenting on this issue appropriate?
What I did:

  1. forked this repository
  2. cloned my forked repository
  3. enabled yarn using corepack enable, according to yarnpkg.com instructions
  4. verified I have Google Chrome Version 101.0.4951.64 (Official Build) (64-bit)
  5. created the .env file and uncommented SELENIUM_BROWSER=chrome and BROWSER_PATH='/usr/bin/google-chrome-stable'
  6. created this branch
  7. commit my changes to the files on the repository
  8. yarn start, no errors
  9. yarn mocha -g 'Tribute Page', since I only changed these tests

Error message:
SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 94 Current browser version is 102.0.5005.115 with binary path /usr/bin/google-chrome-stable

I'm using updated Ubuntu 20.04.1 LTS. Any ideas? Is there a standard test environment suggested, like a container?

EDIT:

Since there is a yarn.lock file and it enforces the ChromeDriver version, I didn't want to alter it. So I downloaded Chromium Version 94.0.4606.0 (Developer Build) (64-bit), unzipped the file, and edited the .env file BROWSER_PATH to point to the file named chrome inside the unzipped folder. Ran the tests again, all passing except D3: Heat Map, which I didn't change. So, I'll make my PR now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants